Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore deferredUpdateMode in case of nested render loops #5982

Merged
merged 1 commit into from Mar 24, 2020

Conversation

guillep
Copy link
Member

@guillep guillep commented Mar 24, 2020

Fix #5976.
NOT - Fix #5977 probably also.

In case of nested render loops, the deferredUpdateMode should be kept and restored correctly.

@pavel-krivanek could you check this fixes both issues?

Restore deferredUpdateMode in case of nested render loops
@guillep guillep added Type: Bug Project: Graphics Athens, Bloc, Morphic, Fonts, etc. labels Mar 24, 2020
@pavel-krivanek
Copy link
Collaborator

Thanks, it fixes the dependency analyzer but not the progress bars

@guillep
Copy link
Member Author

guillep commented Mar 24, 2020

Thanks @pavel-krivanek . I'll ask you then more input on the other issue if you have any, because i cannot reproduce it with just that expression.

@guillep guillep merged commit 1ad0be0 into pharo-project:Pharo9.0 Mar 24, 2020
@guillep guillep deleted the fix/5976 branch March 24, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: Graphics Athens, Bloc, Morphic, Fonts, etc. Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

progress bars show only red box of death DNU in VMWorldRenderer>>#updateDamage:
2 participants