Fix Process>#isSuspended #6197
Merged
Fix Process>#isSuspended #6197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem cases are described with added tests
dionisiydk
commented
Apr 19, 2020
| @@ -233,7 +273,7 @@ ProcessTest >> testIsTerminatingForcedTermination [ | |||
| self assert: terminator identicalTo: process ]. | |||
|
|
|||
| [ process isTerminated ] whileFalse: [ 50 milliSeconds asDelay wait ]. | |||
| self assert: process isSuspended. | |||
| self deny: process isSuspended. | |||
There was a problem hiding this comment.
Notice that terminated process is not suspended.
|
Ohhhhhh excellent. Thanks a lot denis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#isSuspended method returns incorrect process state. For example:
returns true in state variable.
PR describes problem cases with tests and fixes them with Cuis version.