Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5854. SycMethodNameEditor fails with DNU in some cases #6216

Merged
merged 1 commit into from Apr 24, 2020

Conversation

guillep
Copy link
Member

@guillep guillep commented Apr 24, 2020

Fix #5854

This PR enhances the UI so invalid states do not happen (disabling buttons in those cases)

  • Rename MethodNameEditorTest => SycMethodNameEditorTest to follow co…
  • add accessors to SycMethodNameEditor
  • disable parameter edition input and button if no there is no selection
  • many tests

…nvention

- add accessors to SycMethodNameEditor
- disable parameter edition input and button if no there is no selection
- many tests
@Ducasse
Copy link
Member

Ducasse commented Apr 24, 2020

Oh this is cool! I love these tests. So cool feeling.

@Ducasse Ducasse merged commit fe2815c into pharo-project:Pharo9.0 Apr 24, 2020
@guillep guillep deleted the fix/5854 branch December 12, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add argument in extract method throws exception
2 participants