Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove usage of reflectivity to get ast methods by default. #6432

Merged

Conversation

hogoww
Copy link
Contributor

@hogoww hogoww commented May 29, 2020

ASTCCache was using reflectivity by default.
We removed it and are using a strategy instead.

This will allow us to work with bootstrap errors.

@Ducasse Ducasse requested a review from MarcusDenker May 29, 2020 14:07
@MarcusDenker
Copy link
Member

Build fails:

[64] MetacelloNotification: Loaded -> Reflectivity-Tests-tonel.1 --- tonel:///builds/workspace/uest_and_branch_Pipeline_PR-6432/64/src --- cache
[64] Error: This package depends on the following classes:
[64] IconStyler
[64] You must resolve these dependencies before you will be able to load these definitions:
[64] CoverageRubricStyler
[64] CoverageRubricStyler>>#addIconStyle:from:to:
[64] MetalinkIconStyler
[64] MetalinkIconStyler>>#shouldStyle
[64] MetalinkIconStyler>>#iconBlock:
[64] MetalinkIconStyler>>#iconFor:
[64] MetalinkIconStyler>>#iconLabel:
[64] MetalinkIconStyler>>#shouldStyleNode:
[64]

Copy link
Member

@MarcusDenker MarcusDenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the build fails, no CI tests are run (I added the printout as a comment)

…, which are a dependency of Reflectivity-Tests
@hogoww
Copy link
Contributor Author

hogoww commented May 29, 2020

Yes, we are using the CI to test the work, it is not readyl.
We just had to wait for a long time for the CI to run because of the affluence of pull requests :p

@MarcusDenker
Copy link
Member

I looked at the code and yes, it makes sense like this

@hogoww
Copy link
Contributor Author

hogoww commented May 29, 2020

Issues seem unrelated to me, but I don't remember flaky stuff in Athens, so this is weird.
Anyone has an idea ? =]

Copy link
Member

@MarcusDenker MarcusDenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@MarcusDenker MarcusDenker merged commit b043d57 into pharo-project:Pharo9.0 Jun 2, 2020
@hogoww hogoww deleted the removingReflectivityFromASTCache branch October 28, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants