Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Rubric's completion interaction #6630

Merged
merged 6 commits into from Jun 17, 2020
Merged

Enhance Rubric's completion interaction #6630

merged 6 commits into from Jun 17, 2020

Conversation

guillep
Copy link
Member

@guillep guillep commented Jun 17, 2020

Partial Fix for #6311.
This PR introduces the following things:

  • arrow-left and arrow right can be used to navigate the text without losing the completion context
  • the completion context is kept alive even when completion yields no results => this is important to avoid re-scanning the system to look for results that are not there on every keystroke
  • in combination with the two above, arrow left will broaden the completion, and arrow right will re-narrow it. If moving the caret causes moving the selection outside of a word, close the selection context
  • fix string replacement on accept to replace the entire word under the caret

@guillep
Add rubric tests for #wordAtCaret
7ed628c
@guillep
Do not close the completion context if navigating with arrows
2623054
@guillep
Rename narrow completion into refresh selection.
5c5cd6c 
Keep context alive even if we found a result => the user may want to come back.
@guillep
Cleanup
a6ec402
@guillep
Add interaction tests
2aa5c29 
 - ensure a completion context is created
 - typing does not close it
 - left arrow does broaden completion token and search within same context
@guillep
Fix token replacement in completion:
4cc1b14 
 - replace the entire word under selection, not just what is before the caret
 - handle some corner cases
 - with tests
@tesonep tesonep merged commit 18e27b6 into pharo-project:Pharo9.0 Jun 17, 2020
@guillep guillep deleted the fix/6311 branch June 18, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guillep @tesonep