Fix updating tabs in Calypso broken by new notebook widget #6716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as shown when editing method in setUp tab.
dionisiydk
commented
Jun 27, 2020
| ifNotEmpty: [ self selectedIndex: (self selectedIndex - 1) \\ self tabs size + 1 ] | ||
| ifEmpty: [ self selectedIndex: 0 ]. | ||
|
|
||
| super removeTabIndex: anInteger. |
There was a problem hiding this comment.
super implementation performs initial selection reset (self selectedIndex: 0).
It is required to trigger updates of selection when tab is removed. Otherwise new selected tab with same index as removed one will not be updated.
| self tabs add: (self newLabelMorph: aStringOrMorph) beforeIndex: index. | ||
| selectedIndex >= index ifTrue: [ | ||
| "there is now new tab before selected tab" | ||
| self selectedIndex: selectedIndex + 1 ]. |
There was a problem hiding this comment.
This was a missing part. If we do not shift selection index then widget will think that selection is not changed and will not update inserted tab in case when it will be seleted in subsequent calls.
…logic was not really correct.
…the new selection was passed to the method)
|
Thanks you denis! |
|
Having tests is cool. Because this is the only way to control complexity. |
|
failed test was really related: #6728. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to edit setUp method in setUp tab. After accepting changes the browser will show two setUp tabs. That is the bug caused by new notebook (new widget) integration.
In the history I found that #basicUpdateTools was altered to workaround initial tab updating issue: selecting new methods in same class did not update the tab content. This workaround was wrong. At least it should be implemented in explicit place responsible for tab selections (#restoreSelectedTools). But little debugging shows that it was just an issue with new tab implementation (or superclasses which it's based on):
Therefore here I provide correct fix and revert Calypso method