Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMPragmaKeymapBuilder-remove-PragmaCollector #7297

Merged
merged 1 commit into from Sep 28, 2020
Merged

KMPragmaKeymapBuilder-remove-PragmaCollector #7297

merged 1 commit into from Sep 28, 2020

Conversation

MarcusDenker
Copy link
Member

  • KMPragmaKeymapBuilder manages adding/removing methods with pragmas itself. We do therefore not need PragmaCollector but can just use the Pragma API directly.
  • remove unused ivar
  • class side: cleanup code a little

@MarcusDenker
- KMPragmaKeymapBuilder manages adding/removing methods with pragmas …
9eb1ba8 
…itself. We do therefore not need PragmaCollector but can just use the Pragma API directly.

- remove unused ivar
- class side: cleanup code a little
@MarcusDenker
Copy link
Member Author

I will merge this, it is now open for 14 days...

@MarcusDenker MarcusDenker merged commit c0bf9df into pharo-project:Pharo9.0 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MarcusDenker