Improve the method isValidGlobalName #7533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusDenker
added
the
Status: Need more work
|
failing tests, e.g: FluidClassBuilderTest>>testCreateClassWithFullExpandedDefinitionKeepsTheMinimum |
dionisiydk
reviewed
Oct 21, 2020
| self ifEmpty: [ ^ false ]. | ||
|
|
||
| "reserverd default names" | ||
| self = 'NameOfSubclass' ifTrue: [ ^ false ]. | ||
| self = 'TNameOfTrait' ifTrue: [ ^ false ]. | ||
| (#('NameOfSubclass' 'MyClass' 'TNameOfTrait') includes: self) ifTrue: [ ^ false ]. |
There was a problem hiding this comment.
I did not know about this logic. But it's very surprizing. Why we can't have classes with those names? What makes them so special?
There was a problem hiding this comment.
It would be really nice to explain it in the method comment
There was a problem hiding this comment.
@bergel also it should be "reserved" - not "reserverd"
|
@bergel there are broken tests and pending comments in the PR, and a couple of months of inactivity. I'll close it for now, please do not hesitate to reopen it. |
|
@guillep one can not reopen as outside contributor due to permissions. |
|
I can reopen it myself if required, no problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7532