Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21082 Super tearDown need to be called as last message in tearDown of Glamour tests #769

Merged
merged 1 commit into from Jan 28, 2018
Merged

21082 Super tearDown need to be called as last message in tearDown of Glamour tests #769

merged 1 commit into from Jan 28, 2018

Conversation

astares
Copy link
Member

@astares astares commented Jan 27, 2018

@astares
Copy link
Member Author

astares commented Jan 27, 2018

Anyone able to transfer that also into http://smalltalkhub.com/#!/~Moose/Glamour/
(which seems to be the official Glamour repo)

@astares
Copy link
Member Author

astares commented Jan 27, 2018 •
edited

Integrated

Name: Glamour-Morphic-Brick-Tests-CyrilFerlicot.17
Author: CyrilFerlicot
Time: 28 January 2018, 12:30:18.099795 am
UUID: 53bcfc21-2c20-0d00-95b2-0079066f5654
Ancestors: Glamour-Morphic-Brick-Tests-TheIntegrator.16

Add super tearDown at the end of tear down method. (Thanks Astares)

Name: Glamour-Tests-Morphic-CyrilFerlicot.140
Author: CyrilFerlicot
Time: 28 January 2018, 12:30:54.905795 am
UUID: c3592e24-2c20-0d00-95b3-4873066f5654
Ancestors: Glamour-Tests-Morphic-TorstenBergmann.139

Add super tearDown at the end of tear down method. (Thanks Astares)

Name: Glamour-Tests-Core-CyrilFerlicot.115
Author: CyrilFerlicot
Time: 28 January 2018, 12:31:16.009795 am
UUID: 5b5b7025-2c20-0d00-95b4-a39d066f5654
Ancestors: Glamour-Tests-Core-TorstenBergmann.114

Add super tearDown at the end of tear down method. (Thanks Astares)

MarcusDenker
MarcusDenker approved these changes Jan 28, 2018
View reviewed changes
Copy link
Member

@MarcusDenker MarcusDenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@MarcusDenker MarcusDenker merged commit f7a4d8e into pharo-project:development Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDenker MarcusDenker MarcusDenker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@astares @MarcusDenker