Compilerbased-meta-data-tagging #7779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn a property that the compiler sets at compile time.
MarcusDenker
added
the
Status: Need more work
…Not a huge problem
MarcusDenker
added
Status: Tests passed please review!
and removed
Status: Need more work
MarcusDenker
added a commit
to pharo-spec/NewTools
that referenced
this pull request
Nov 23, 2020
This is a bit slower until we merge pharo-project/pharo#7779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes #containsHalt to not scan the bytecode but instead return a property that the compiler sets at compile time.
It adds a dedicated visitor for this, but for now calls it when we do semantic analysis (could be moved later to the compiler, but that needs some refactoring, I added it to the backlog)