Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21218 Lint cleanup AnnouncerTest and WeakAnnouncerTest #784

Merged
merged 1 commit into from Feb 2, 2018
Merged

21218 Lint cleanup AnnouncerTest and WeakAnnouncerTest #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 14 additions & 15 deletions src/Announcements-Tests-Core/AnnouncerTest.class.st
View file
Open in desktop
Expand Up @@ -35,15 +35,14 @@ AnnouncerTest >> setUp [

{ #category : #tests }
AnnouncerTest >> testAnnounceClass [
self assert: (announcer announce: AnnouncementMockA)
class = AnnouncementMockA
self assert: (announcer announce: AnnouncementMockA) class equals: AnnouncementMockA
]

{ #category : #tests }
AnnouncerTest >> testAnnounceInstance [
| instance |
instance := AnnouncementMockA new.
self assert: (announcer announce: instance) = instance
self assert: (announcer announce: instance) equals: instance
]

{ #category : #tests }
Expand Down Expand Up @@ -77,7 +76,7 @@ AnnouncerTest >> testNoArgBlock [
counter := nil.
announcer subscribe: AnnouncementMockA do: [ counter := 1 ].
announcer announce: AnnouncementMockA new.
self assert: counter = 1
self assert: counter equals: 1
]

{ #category : #tests }
Expand Down Expand Up @@ -118,7 +117,7 @@ AnnouncerTest >> testSubscribeBlock [

announcement := nil.
instance := announcer announce: AnnouncementMockA.
self assert: announcement = instance.
self assert: announcement equals: instance.

announcement := nil.
instance := announcer announce: AnnouncementMockB.
Expand All @@ -134,7 +133,7 @@ AnnouncerTest >> testSubscribeClassWithExclusion [

announcement := nil.
instance := announcer announce: AnnouncementMockB.
self assert: announcement = instance.
self assert: announcement equals: instance.

announcement := nil.
instance := announcer announce: AnnouncementMockC.
Expand Down Expand Up @@ -162,7 +161,7 @@ AnnouncerTest >> testSubscribeOnSpecificAnnouncer [

announcement := nil.
instance := announcer announce: (AnnouncementMockB with: #expectedParam).
self assert: announcement = instance.
self assert: announcement equals: instance.

announcement := nil.
instance := announcer announce: (AnnouncementMockC with: #expectedParam).
Expand Down Expand Up @@ -192,15 +191,15 @@ AnnouncerTest >> testSubscribeSet [

announcement := nil.
instance := announcer announce: AnnouncementMockA.
self assert: announcement = instance.
self assert: announcement equals: instance.

announcement := nil.
instance := announcer announce: AnnouncementMockB.
self assert: announcement isNil.

announcement := nil.
instance := announcer announce: AnnouncementMockC.
self assert: announcement = instance
self assert: announcement equals: instance
]

{ #category : #'tests - subscribing' }
Expand All @@ -212,11 +211,11 @@ AnnouncerTest >> testSubscribeSetWithExclusion [

announcement := nil.
instance := announcer announce: AnnouncementMockA.
self assert: announcement = instance.
self assert: announcement equals: instance.

announcement := nil.
instance := announcer announce: AnnouncementMockB.
self assert: announcement = instance.
self assert: announcement equals: instance.

announcement := nil.
instance := announcer announce: AnnouncementMockC.
Expand All @@ -236,7 +235,7 @@ AnnouncerTest >> testSubscribeSetWithExclusionOfMultipleAnnouncements [

announcement := nil.
instance := announcer announce: AnnouncementMockB.
self assert: announcement = instance.
self assert: announcement equals: instance.

announcement := nil.
instance := announcer announce: AnnouncementMockC.
Expand All @@ -256,7 +255,7 @@ AnnouncerTest >> testSubscribeSetWithExclusionOfSetItem [

announcement := nil.
instance := announcer announce: AnnouncementMockC.
self assert: announcement = instance
self assert: announcement equals: instance
]

{ #category : #'tests - subscribing' }
Expand All @@ -272,11 +271,11 @@ AnnouncerTest >> testSubscribeSubclass [

announcement := nil.
instance := announcer announce: AnnouncementMockB.
self assert: announcement = instance.
self assert: announcement equals: instance.

announcement := nil.
instance := announcer announce: AnnouncementMockC.
self assert: announcement = instance.
self assert: announcement equals: instance.
]

{ #category : #tests }
Expand Down
30 changes: 15 additions & 15 deletions src/Announcements-Tests-Core/WeakAnnouncerTest.class.st
View file
Open in desktop
Expand Up @@ -17,42 +17,42 @@ WeakAnnouncerTest >> benchManyWeakGuys [

50000 timesRepeat: [ (ann weak when: Announcement send: #value to: object) ].

self assert: (ann numberOfSubscriptions = 50000).
self assert: ann numberOfSubscriptions equals: 50000.

Smalltalk garbageCollect.

time := [object := nil.
Smalltalk garbageCollect.
]timeToRun.

self assert: (ann numberOfSubscriptions = 0).
self assert: ann numberOfSubscriptions equals: 0.
^ time
]

{ #category : #benchmarks }
WeakAnnouncerTest >> benchWeakSubscriptionDynamic [

" run me to see how expensive becomeForward: is (compared to #benchWeakSubscriptionStatic ) "
"Run me to see how expensive #becomeForward: is (compared to #benchWeakSubscriptionStatic )"

| object ann |

object := Object new.
ann := Announcer new.

^ [
^[
1000 timesRepeat: [ (ann when: Announcement send: #value to: object) makeWeak ].
] timeToRun
]

{ #category : #benchmarks }
WeakAnnouncerTest >> benchWeakSubscriptionStatic [
"Run me to see how cheap object creation is (compared to #benchWeakSubscriptionDynamic ) "

" run me to see how cheap object creation is (compared to #benchWeakSubscriptionDynamic ) "
| object ann |

object := Object new.
ann := Announcer new.

^ [
^[
1000 timesRepeat: [ (ann weak when: Announcement send: #value to: object) ].
] timeToRun
]
Expand Down Expand Up @@ -92,11 +92,11 @@ WeakAnnouncerTest >> testNoWeakBlock [

Smalltalk garbageCollect.
announcer announce: AnnouncementMockA.
self assert: counter = 1.
self assert: counter equals: 1.

Smalltalk garbageCollect.
announcer announce: AnnouncementMockA.
self assert: counter = 2
self assert: counter equals: 2
]

{ #category : #tests }
Expand All @@ -119,14 +119,14 @@ WeakAnnouncerTest >> testWeakDoubleAnnouncer [
a2 weak when: Announcement send: #abcdef to: o.

self
assert: a1 subscriptions numberOfSubscriptions = 1;
assert: a2 subscriptions numberOfSubscriptions = 1.
assert: a1 subscriptions numberOfSubscriptions equals: 1;
assert: a2 subscriptions numberOfSubscriptions equals: 1.

3 timesRepeat: [ Smalltalk garbageCollect ].

self
assert: a1 subscriptions numberOfSubscriptions = 1;
assert: a2 subscriptions numberOfSubscriptions = 1.
assert: a1 subscriptions numberOfSubscriptions equals: 1;
assert: a2 subscriptions numberOfSubscriptions equals: 1.

o := nil.

Expand All @@ -151,13 +151,13 @@ WeakAnnouncerTest >> testWeakObject [
" shouldn't go away, we are still holding a reference to 'forwarder': "
Smalltalk garbageCollect.
announcer announce: AnnouncementMockA.
self assert: counter = 1.
self assert: counter equals: 1.

" should go away as we let the only reference to 'forwarder' go: "
forwarder := nil.
Smalltalk garbageCollect.
announcer announce: AnnouncementMockA.
self assert: counter = 1
self assert: counter equals: 1
]

{ #category : #tests }
Expand Down