Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban rule "class not referenced" for WebBrowser subclasses #7847

Merged
merged 3 commits into from Nov 26, 2020
Merged

Ban rule "class not referenced" for WebBrowser subclasses #7847

merged 3 commits into from Nov 26, 2020

Conversation

astares
Copy link
Member

@astares astares commented Nov 24, 2020

Fix #7846

@MarcusDenker
Copy link
Member

maybe better is to implement #isUsed like in TestCase and similar classes

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Nov 25, 2020
@astares
Copy link
Member Author

astares commented Nov 25, 2020

@MarcusDenker Did'nt know about #isUsed. I changed the PR to use it, no need for the banned rule and manifest now.

Ready for a second review

@MarcusDenker MarcusDenker removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label Nov 26, 2020
@MarcusDenker MarcusDenker merged commit 1210aeb into pharo-project:Pharo9.0 Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDenker MarcusDenker MarcusDenker approved these changes

Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ban rule "class not referenced" for WebBrowser subclasses
2 participants
@astares @MarcusDenker