Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Compiler plugin implementation #8114

Closed
wants to merge 2 commits into from
Closed

Improve Compiler plugin implementation #8114

wants to merge 2 commits into from

Conversation

astares
Copy link
Member

@astares astares commented Dec 15, 2020

fix #8113

@astares
Copy link
Member Author

astares commented Dec 15, 2020

image

@MarcusDenker
Copy link
Member

One thing to care about: there might be users that subclass the current abstract class.

Another idea was that it had AST in it's name as there might me other plugins added later that are doing things at different stages of the compiler. There will be for sure not just one CompilerPlugin.

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Dec 15, 2020
@astares
Copy link
Member Author

astares commented Dec 15, 2020

OK - so what do you propose:

  • OCCompilerPlugin (abstract)
    -- OCASTCompilerPlugin (abstract)
    --- OCDynamicASTCompilerPlugin
    --- OCStaticASTCompilerPlugin
    ---- FFICompilerPlugin
    ---- ASTPluginMeaningOfLife
    -- [OCOtherStageCompilerPlugin] (abstract) then later
    --- ...

@astares astares closed this Dec 15, 2020
@MarcusDenker MarcusDenker reopened this Dec 15, 2020
@guillep
Copy link
Member

guillep commented Dec 22, 2020

I had a brief look and it looks ok to me. I like the class comments.

Is this safe for integration?

@guillep guillep changed the base branch from Pharo9.0 to Pharo10 September 21, 2021 12:51
@astares
Copy link
Member Author

astares commented Oct 5, 2022

This is for P10 - but we develop for P11 now.

I created a new up to date PR against "Pharo11" branches (see #11761)

@astares astares closed this Oct 5, 2022
@astares astares mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits. Version: Pharo 11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Compiler plugin implementation
3 participants
@astares @MarcusDenker @guillep