Fix a regression from earlier pharo that used to perserve order in #8402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged. |
|
Thanks Todd. Could you provide a couple of tests so that we avoid regression in the future. |
|
Yes, I will make a couple tests and add them to my branch. Don't merge yet. :-)
… On Jan 21, 2021, at 10:03 AM, StéphaneDucasse ***@***.***> wrote:
Thanks Todd. Could you provide a couple of tests so that we avoid regression in the future.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8402 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABIVKHWY3A4Q2XDSKTPSKLS3BT7RANCNFSM4WNIPZCA>.
|
|
Congrats on merging your first pull request! Do another one! We try to have a list of (relatively) easy issues here: https://github.com/orgs/pharo-project/projects/8.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sequences.
My first PR in Pharo created from web console. This was not possible from the Iceberg panel - refused my credentials. I have that problem a lot.