Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8564-Running-tests-from-the-command-line-does-not-execute-parametrized-cases #8565

Merged
merged 3 commits into from Feb 19, 2021
Merged

8564-Running-tests-from-the-command-line-does-not-execute-parametrized-cases #8565

merged 3 commits into from Feb 19, 2021

Conversation

tesonep
Copy link
Collaborator

@tesonep tesonep commented Feb 12, 2021

Fixes #8564

@tesonep tesonep requested a review from guillep February 12, 2021 19:25
@tesonep
Copy link
Collaborator Author

tesonep commented Feb 12, 2021

We have a problem: the limitation of the JUnit XML format parsed by Jenkins. It does not support having more information about the parametrized test.

@guillep
Copy link
Member

guillep commented Feb 12, 2021

We have a problem: the limitation of the JUnit XML format parsed by Jenkins. It does not support having more information about the parametrized test.

Interesting, I'll look for a spec of the JUnit XML format. Do you have a link? Would be nice to have it linked in the issue for future reference.

@guillep
Copy link
Member

guillep commented Feb 12, 2021 •
edited by unfurl-links bot

There is one in form of an xsd here:

https://github.com/windyroad/JUnit-Schema

GitHub
XSD for Apache Ant's JUnit output. Contribute to windyroad/JUnit-Schema development by creating an account on GitHub.

@tesonep
Copy link
Collaborator Author

tesonep commented Feb 12, 2021

I had checked the same XSD.
Maybe we can try to see what happens if the method name is not a Java valid symbol.

@guillep
Copy link
Member

guillep commented Feb 12, 2021

I don't think Jenkins will check that... We can try that...

@Ducasse Ducasse added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Feb 14, 2021
@tesonep tesonep removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label Feb 19, 2021
@tesonep tesonep merged commit ac4bf08 into pharo-project:Pharo9.0 Feb 19, 2021
@tesonep tesonep deleted the 8564-Running-tests-from-the-command-line-does-not-execute-parametrized-cases branch March 31, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep Awaiting requested review from guillep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running tests from the command line does not execute parametrized cases
3 participants
@tesonep @guillep @Ducasse