8694-Instance-of-DoItVariable-did-not-understand-markRead #8774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrap a temporary variable. fixes pharo-project#8694
…he undeclared temp
dionisiydk
reviewed
Mar 12, 2021
MarcusDenker
added
Status: Need more work
dionisiydk
added a commit
to dionisiydk/pharo
that referenced
this pull request
Apr 20, 2021
… message and use a dispatch to the variable instead: #analyzeRead:by: and analyzeWrite:by: The changes are based on recently introduced visit~ConcreteTypeOf~Variable: methods in AST visitors. Related to this idea several renames are introduced: #analyseEscapingRead: and #analyseEscapingWrite: are replaced by #analyzeLocalVariableRead: and #analyzeLocalVariableWrite: accordingly The driver for this refactoring is DoItVariable issue (recently fixed pharo-project#8774) when it represents the external temp during a compilation. Compiler is trying to call some locals specific code during doIt compilation and it was failing because DoItVariable is not a local for newly compiled doIt methods. The Marcus fix introduced missing methods. But this PR allows to avoid it completely. 2. It optimizes how variables are represented in doIt expressions. The idea is that only variables which can't be used directly in doIts needs to be converted. And it is only local variables. Therefore Variable>>#asDoItVariable will returns self as default behaviour. And local variables will be converted to DoItVariable instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoItVariable needs to forward the read/write usage messages as it can wrap a temporary variable.
fixes #8694