8655-SurfacePluginDLL-is-crashing-with-the-headless-VM-at-restart #8804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation was using just FFI to access the plugin. This is not good, as the initialization of the plugin is not guarantee when using direct FFI When combined with the new headless VM. Fix pharo-project#8655
guillep
deleted the
8655-SurfacePluginDLL-is-crashing-with-the-headless-VM-at-restart
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for primitives defined in the SurfacePlugin.
The old implementation was using just FFI to access the plugin.
This is not good, as the initialization of the plugin is not guaranteed when using direct FFI
This change is backwards compatible and fixes the problem when combined with the new headless VM.
Fix #8655