New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #8844 Avoid hardcoded #doTerminationFromYourself as a criteria #8845
Conversation
…a criteria for the isTerminated method
Somehow it looks as if the tests time out on all platforms |
…ests expectations
Thanks, it looks like some debugger tests don't like the feature preventing 'cannot return' errors (i.e. simply suspending accidentally resumed terminated processes, without raising an error). So I just commented the feature out (leaving the other code intact) to make it available for future consideration. Sorry for missing this :) |
Hi @isCzech . Sorry that I was not clear. But I expected that you will push your changes on top of mine. Now it will cause a conflict with my PR (#8567 ). And considering the size of my changes I would be very happy to avoid remerging. It will require another pass on testing and rethinking of what I get. So please wait the integration of #8567 |
Hi @dionisiydk , |
Hi denis I heard today Pablo telling that he had a look and like it but wants guille to have a look too so that they can make sure that it is ok. S. |
Hi All, |
same as with #8993, we want this, but is very dangerous so I am deferring. |
Yes this is good to relabel it. |
Hi all, it's been really difficult to review the batch of issues (#8567 , #8845, #9137, #8993, #8509). @tesonep is correctly (!!) proposing to my ear that we make a single PR joining all of them to reduce the merge noise, let the CI test the combination of all issues. I then propose that we eagerly merge this (meta) PR and be ready to quickly apply hot-fixes as soon as possible or revert it in case of fire. Thoughts? @dionisiydk @Ducasse @isCzech @estebanlm |
Ok for me :) |
Superseeded by #10429 |
Agreed because after they become baby monsters that grow up and that we cannot handle. |
Fixes #8844