Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify-OCUndeclaredVariableWarning #8943

Merged
merged 1 commit into from Apr 3, 2021
Merged

Simplify-OCUndeclaredVariableWarning #8943

merged 1 commit into from Apr 3, 2021

Conversation

MarcusDenker
Copy link
Member

  • OCShadowVariableWarning does not need the variable, the defining node is enough

OCASTSemanticAnalyzer

  • simplify declareVariableNode: as:
  • add shadowingVariable: to be more in sync witht he other semantic warnind method (like #undeclaredVariable:)

@MarcusDenker
- OCShadowVariableWarning does not need the variable, the defining no…
bd6f592 
…de is enough

OCASTSemanticAnalyzer
- simplify declareVariableNode: as:
- add shadowingVariable: to be more in sync witht he other semantic warnind method (like #undeclaredVariable:)
@Ducasse Ducasse merged commit 089dead into pharo-project:Pharo9.0 Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcusDenker @Ducasse