Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing method to ObservableSlot #9427

Merged
merged 2 commits into from Jun 10, 2021
Merged

Add missing method to ObservableSlot #9427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea8074
this method is needed and missing :)
estebanlm Jun 10, 2021
5bf8f41
add test
estebanlm Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/VariablesLibrary-Tests/ObservableSlotTest.class.st
View file
Open in desktop
Expand Up @@ -51,6 +51,12 @@ ObservableSlotTest >> testExplicitNotifyUnexistentPropertyChangedRaisesError [
self should: [ point notifyPropertyChanged: #z ] raise: SlotNotFound
]

{ #category : #tests }
ObservableSlotTest >> testIsObservableSlot [

self assert: (point class slotNamed: 'x') isObservableSlot
]

{ #category : #tests }
ObservableSlotTest >> testObservableSlotAssignReturnsValue [
"When assigning to a Observable Slot, the return value should be the value"
Expand Down
6 changes: 6 additions & 0 deletions src/VariablesLibrary/ObservableSlot.class.st
View file
Open in desktop
Expand Up @@ -61,6 +61,12 @@ ObservableSlot >> initialize: anObject [
super write: ObservableValueHolder new to: anObject
]

{ #category : #testing }
ObservableSlot >> isObservableSlot [

^ true
]

{ #category : #'meta-object-protocol' }
ObservableSlot >> rawRead: anObject [
^ super read: anObject
Expand Down