Cleanup GlorpLoggingTest hierarchy

Fix #104
pharo-rdbms · Jun 26, 2023 · 51279f4 · 51279f4
1 parent f3dc14a
commit 51279f4
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 38 deletions.
diff --git a/src/Glorp-Integration-Tests/GlorpLoggingTest.class.st b/src/Glorp-Integration-Tests/GlorpLoggingTest.class.st
@@ -14,46 +14,44 @@ GlorpLoggingTest class >> isAbstract [
 	^ self name = #GlorpLoggingTest
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpLoggingTest >> assertExpectedInsertStatements [
 
-	self subclassResponsibility 
+	self subclassResponsibility
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpLoggingTest >> assertExpectedLoginStatements [
 
-	self subclassResponsibility 
+	self subclassResponsibility
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpLoggingTest >> assertExpectedSelectAllStatements [
 
 	self subclassResponsibility
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpLoggingTest >> assertExpectedSelectWithLikeStatements [
 
 	self subclassResponsibility
 ]
 
-{ #category : #running }
+{ #category : #accessing }
 GlorpLoggingTest >> coveredPlatformType [
 
-	self subclassResponsibility 
+	self subclassResponsibility
 ]
 
 { #category : #'logger - api' }
 GlorpLoggingTest >> cr [
-
-	" do nothing "
+	"Do nothing"
 ]
 
 { #category : #'logger - api' }
 GlorpLoggingTest >> flush [
-
-	" do nothing "
+	"Do nothing"
 ]
 
 { #category : #'logger - api' }
@@ -65,8 +63,7 @@ GlorpLoggingTest >> nextPutAll: aString [
 { #category : #running }
 GlorpLoggingTest >> runCase [
 
-	(GlorpDatabaseLoginResource defaultLogin database isKindOf:
-		 self coveredPlatformType)
+	(GlorpDatabaseLoginResource defaultLogin database isKindOf: self coveredPlatformType)
 		ifTrue: [ super runCase ]
 		ifFalse: [ self skip ]
 ]
@@ -88,40 +85,43 @@ GlorpLoggingTest >> setUp [
 GlorpLoggingTest >> tearDown [
 
 	session accessor logging: false.
-	session rollbackTransaction.
-	session reset.
+	session
+		rollbackTransaction;
+		reset.
 	session := nil.
 	super tearDown
 ]
 
-{ #category : #running }
+{ #category : #tests }
 GlorpLoggingTest >> testInsert [
 
-	session loginIfError: [ self fail ].
-	session beginTransaction.
-	session writeRow: session system exampleAddressRowForOrdering1.
+	session
+		loginIfError: [ self fail ];
+		beginTransaction;
+		writeRow: session system exampleAddressRowForOrdering1.
 
 	self assertExpectedInsertStatements
 ]
 
-{ #category : #running }
+{ #category : #tests }
 GlorpLoggingTest >> testLogin [
 
 	session loginIfError: [ self fail ].
-	
+
 	self assertExpectedLoginStatements
 ]
 
-{ #category : #running }
+{ #category : #tests }
 GlorpLoggingTest >> testSelectAll [
 
-	session loginIfError: [ self fail ].
-	session read: GlorpBankTransaction.
-
+	session
+		loginIfError: [ self fail ];
+		read: GlorpBankTransaction.
+
 	self assertExpectedSelectAllStatements
 ]
 
-{ #category : #running }
+{ #category : #tests }
 GlorpLoggingTest >> testSelectWithLike [
 
 	| query |

diff --git a/src/Glorp-Integration-Tests/GlorpPostgreSQLLoggingTest.class.st b/src/Glorp-Integration-Tests/GlorpPostgreSQLLoggingTest.class.st
@@ -4,7 +4,7 @@ Class {
 	#category : #'Glorp-Integration-Tests-Database'
 }
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpPostgreSQLLoggingTest >> assertExpectedInsertStatements [
 
 	self assert: loggedStatements size equals: 5.
@@ -17,15 +17,15 @@ GlorpPostgreSQLLoggingTest >> assertExpectedInsertStatements [
 		'INSERT INTO GR_ADDRESS (ID,STREET,HOUSE_NUM)  VALUES (1,''Alpha'',''300'')'
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpPostgreSQLLoggingTest >> assertExpectedLoginStatements [
 
 	self assert: loggedStatements size equals: 2.
 	self assert: (loggedStatements at: 1) equals: 'Login'.
 	self assert: (loggedStatements at: 2) equals: 'Login finished'
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpPostgreSQLLoggingTest >> assertExpectedSelectAllStatements [
 
 	self assert: loggedStatements size equals: 3.
@@ -38,7 +38,7 @@ GlorpPostgreSQLLoggingTest >> assertExpectedSelectAllStatements [
  FROM BANK_TRANS t1'
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpPostgreSQLLoggingTest >> assertExpectedSelectWithLikeStatements [
 
 	self assert: loggedStatements size equals: 3.
@@ -51,7 +51,7 @@ GlorpPostgreSQLLoggingTest >> assertExpectedSelectWithLikeStatements [
  WHERE (t1.STREET LIKE ''Be%'')'
 ]
 
-{ #category : #running }
+{ #category : #accessing }
 GlorpPostgreSQLLoggingTest >> coveredPlatformType [
 
 	^ PostgreSQLPlatform

diff --git a/src/Glorp-Integration-Tests/GlorpSQLiteLoggingTest.class.st b/src/Glorp-Integration-Tests/GlorpSQLiteLoggingTest.class.st
@@ -4,7 +4,7 @@ Class {
 	#category : #'Glorp-Integration-Tests-Database'
 }
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpSQLiteLoggingTest >> assertExpectedInsertStatements [
 
 	self assert: loggedStatements size equals: 4.
@@ -17,15 +17,15 @@ GlorpSQLiteLoggingTest >> assertExpectedInsertStatements [
 		'INSERT INTO GR_ADDRESS (ID,STREET,HOUSE_NUM)  VALUES (?,?,?)  #(1 ''Alpha'' ''300'')'
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpSQLiteLoggingTest >> assertExpectedLoginStatements [
 
 	self assert: loggedStatements size equals: 2.
 	self assert: (loggedStatements at: 1) equals: 'Login'.
 	self assert: (loggedStatements at: 2) equals: 'Login finished'
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpSQLiteLoggingTest >> assertExpectedSelectAllStatements [
 
 	self assert: loggedStatements size equals: 3.
@@ -38,7 +38,7 @@ GlorpSQLiteLoggingTest >> assertExpectedSelectAllStatements [
  FROM BANK_TRANS t1  an OrderedCollection()'
 ]
 
-{ #category : #running }
+{ #category : #asserting }
 GlorpSQLiteLoggingTest >> assertExpectedSelectWithLikeStatements [
 
 	self assert: loggedStatements size equals: 3.
@@ -51,8 +51,8 @@ GlorpSQLiteLoggingTest >> assertExpectedSelectWithLikeStatements [
  WHERE (t1.STREET LIKE ?)  an OrderedCollection(''Be%'')'
 ]
 
-{ #category : #running }
+{ #category : #accessing }
 GlorpSQLiteLoggingTest >> coveredPlatformType [
 
-	^ SQLite3Platform 
+	^ SQLite3Platform
 ]