Adds single cache for type resolvers (avoid duplication) #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use a FilteredTypeResolver, e.g. with
Animal
as the root class withDog
andCat
as different types, if you read by looking atDog
and then look by looking atAnimal
(e.g.session read: Animal
), you'll end up with two different instances stored in two different caches (one forAnimal
and another one forDog
).This change removes that duplication, and always uses the root descriptor class for the cache of all the inherited instances.
It's old code I'm merging in order to catch up with the main codebase, the discussion comes from here:
https://groups.google.com/g/glorp-group/c/eccmfOergeY/m/OEHmWD-cDgAJ
I've been using it in production since many years now, and all the Glorp test suite pass with this modification in.