Merge pull request #649 from pharo-spec/dev-2.0

sync
pharo-spec · Jan 8, 2024 · 786cbcb · 786cbcb
2 parents 808c56c + 73a506d
commit 786cbcb
Show file tree

Hide file tree

Showing 60 changed files with 3,177 additions and 1,251 deletions.
diff --git a/src/BaselineOfNewTools/BaselineOfNewTools.class.st b/src/BaselineOfNewTools/BaselineOfNewTools.class.st
@@ -82,15 +82,15 @@ BaselineOfNewTools >> baseline: spec [
 			package: 'NewTools-RewriterTools' with: [ spec requires: #('NewTools-RewriterTools-Backend') ];
 			package: 'NewTools-RewriterTools-Backend-Tests' with: [ spec requires: #('NewTools-RewriterTools-Backend') ];
 			package: 'NewTools-RewriterTools-Tests' with: [ spec requires: #('NewTools-RewriterTools') ];
+			"Profiler"
+			package: 'NewTools-ProfilerUI';
 			"Scopes Editor"
 			package: 'NewTools-Scopes';
 			package: 'NewTools-Scopes-Editor' with: [ spec requires: #('NewTools-Scopes') ];
 			package: 'NewTools-Scopes-Tests';
 			package: 'NewTools-Scopes-Resources-A-Tests';
 			package: 'NewTools-Scopes-Resources-B-Tests';
-			package: 'NewTools-Scopes-Resources-C-Tests';
-			"ProfilerUI"
-			package: 'NewTools-ProfilerUI'.
+			package: 'NewTools-Scopes-Resources-C-Tests'.
 
 		spec
 			group: 'Core' with: #( 'NewTools-Core' 'NewTools-Morphic' );
@@ -134,12 +134,11 @@ BaselineOfNewTools >> baseline: spec [
 			group: #FileBrowser with: #( 
 						'NewTools-FileBrowser' 
 						'NewTools-FileBrowser-Tests' );
-   		group: #RewriterTools with: #(
-			   		'NewTools-RewriterTools-Backend'
-			   		'NewTools-RewriterTools'
-			   		'NewTools-RewriterTools-Backend-Tests'
-			   		'NewTools-RewriterTools-Tests' );
-			group: #ProfilerUI with: #( 'NewTools-ProfilerUI' );
+      			group: #RewriterTools with: #(
+				    		'NewTools-RewriterTools-Backend'
+				    		'NewTools-RewriterTools'
+				    		'NewTools-RewriterTools-Backend-Tests'
+				    		'NewTools-RewriterTools-Tests' );
 			"ScopesEditor"
 			group: #ScopesEditor with: #(
 						'NewTools-Scopes' 
@@ -153,13 +152,12 @@ BaselineOfNewTools >> baseline: spec [
 						'Inspector' 
 						'CritiqueBrowser' 
 						'Debugger'
-						'SystemReporter' 
+				   		'SystemReporter' 
 						'FontChooser' 
 						'Methods'
-						'Spotter'
-						'RewriterTools'
-						'ScopesEditor'
-						'ProfilerUI') ]
+				   		'Spotter'
+            					'RewriterTools'
+						'ScopesEditor') ]
 ]
 
 { #category : 'external projects' }

diff --git a/src/NewTools-FontChooser/StFontChooserPresenter.class.st b/src/NewTools-FontChooser/StFontChooserPresenter.class.st
@@ -167,9 +167,8 @@ StFontChooserPresenter >> initializeDialogWindow: aDialogWindowPresenter [
 	super initializeDialogWindow: aDialogWindowPresenter.
 
 	aDialogWindowPresenter
-		addButton: 'Apply' do: [ :presenter | self applyChanges ];
 		addButton: 'Update' do: [ :presenter | self updateFonts ];
-		okAction: [ self applyChanges ].
+		addDefaultButton: 'Apply' do: [ :presenter | self applyChanges ]
 
 ]
 

diff --git a/src/NewTools-Gtk/StGtkDebugSession.class.st b/src/NewTools-Gtk/StGtkDebugSession.class.st
@@ -20,7 +20,7 @@ StGtkDebugSession >> application: anApplication [
 	application := anApplication
 ]
 
-{ #category : 'private' }
+{ #category : 'initialization' }
 StGtkDebugSession >> initialize [
 
 	super initialize. 

diff --git a/src/NewTools-Gtk/StPharoGtkConfiguration.class.st b/src/NewTools-Gtk/StPharoGtkConfiguration.class.st
@@ -15,14 +15,14 @@ StPharoGtkConfiguration >> commonStyle [
 
 	^ '
 /* compact toolbar */
-toolbar.stToolbar { font-size: 0.7em }
-toolbar.stToolbar toolbutton > button { padding: 2px; margin: 2px }
+toolbar.stToolbar { font-size: 0.7em; }
+toolbar.stToolbar toolbutton > button { padding: 2px; margin: 2px; }
 
-.dim { color: LightSlateGrey }
+.dim { color: LightSlateGrey; }
 .codePopover, .codePopover text { 
 	background-color: transparent;
 }
-.scrollbarPopoverLarge { min-height: 350px }
+.scrollbarPopoverLarge { min-height: 350px; }
 '
 ]
 
@@ -41,7 +41,7 @@ StPharoGtkConfiguration >> configureOSX: anApplication [
 
 	self installTheme: self macThemeName.
 	self addCSSProviderFromString: '
-.code { font: 12pt "Monaco" }
+.code { font: 12pt "Monaco"; }
 '
 ]
 
@@ -50,7 +50,7 @@ StPharoGtkConfiguration >> configureUnix: anApplication [
 
 	self unixThemeName ifNotNil: [ :aName | self installTheme: aName ].
 	self addCSSProviderFromString: '
-.code { /* font: 10pt "Source Code Pro" */ }
+/* .code { font: 10pt "Source Code Pro" } */
 '
 ]
 
@@ -59,7 +59,7 @@ StPharoGtkConfiguration >> configureWindows: anApplication [
 
 	self installTheme: self windowsThemeName.
 	self addCSSProviderFromString: '
-.code { font: 10pt "Microsoft Sans Serif" }
+.code { font: 10pt "Microsoft Sans Serif"; }
 '
 ]
 

diff --git a/src/NewTools-Gtk/StPharoGtkDarkConfiguration.class.st b/src/NewTools-Gtk/StPharoGtkDarkConfiguration.class.st
@@ -9,6 +9,12 @@ Class {
 	#package : 'NewTools-Gtk'
 }
 
+{ #category : 'testing' }
+StPharoGtkDarkConfiguration >> isDarkTheme [
+
+	^ true
+]
+
 { #category : 'accessing' }
 StPharoGtkDarkConfiguration >> macThemeName [
 

diff --git a/src/NewTools-Inspector/StInspector.class.st b/src/NewTools-Inspector/StInspector.class.st
@@ -1,3 +1,16 @@
+"
+I am an inspector of objects. 
+I offer multiple views using a miller list as a navigation. 
+One particular feature is that you can use the evaluator tab to enter code, and evaluating it results in opening another pane to the right.
+
+The object finder asks dynamically the object for the actual presentations that are displayed in each pane.
+
+Example:
+self openOn: Smalltalk.
+
+Register it as a replacement for inspector:
+self registerToolsOn: Smalltalk tools.
+"
 Class {
 	#name : 'StInspector',
 	#superclass : 'StInspectorPresenter',

diff --git a/src/NewTools-MethodBrowsers/AbstractMessageCentricBrowser.class.st b/src/NewTools-MethodBrowsers/AbstractMessageCentricBrowser.class.st
@@ -1,6 +1,6 @@
 Class {
 	#name : 'AbstractMessageCentricBrowser',
-	#superclass : 'AbstractMessageCentricBrowserPresenter',
+	#superclass : 'StAbstractMessageCentricBrowserPresenter',
 	#category : 'NewTools-MethodBrowsers-Deprecated',
 	#package : 'NewTools-MethodBrowsers',
 	#tag : 'Deprecated'

diff --git a/src/NewTools-MethodBrowsers/MessageBrowser.class.st b/src/NewTools-MethodBrowsers/MessageBrowser.class.st
@@ -1,6 +1,6 @@
 Class {
 	#name : 'MessageBrowser',
-	#superclass : 'StMessageBrowserPresenter',
+	#superclass : 'StMessageBrowser',
 	#category : 'NewTools-MethodBrowsers-Deprecated',
 	#package : 'NewTools-MethodBrowsers',
 	#tag : 'Deprecated'

diff --git a/src/NewTools-MethodBrowsers/MessageBrowserPresenter.class.st b/src/NewTools-MethodBrowsers/MessageBrowserPresenter.class.st
@@ -1,6 +1,6 @@
 Class {
 	#name : 'MessageBrowserPresenter',
-	#superclass : 'StMessageBrowserPresenter',
+	#superclass : 'StMessageBrowser',
 	#category : 'NewTools-MethodBrowsers-Deprecated',
 	#package : 'NewTools-MethodBrowsers',
 	#tag : 'Deprecated'

diff --git a/src/NewTools-MethodBrowsers/MessageList.class.st b/src/NewTools-MethodBrowsers/MessageList.class.st
@@ -1,6 +1,6 @@
 Class {
 	#name : 'MessageList',
-	#superclass : 'MessageListPresenter',
+	#superclass : 'StMessageListPresenter',
 	#category : 'NewTools-MethodBrowsers-Deprecated',
 	#package : 'NewTools-MethodBrowsers',
 	#tag : 'Deprecated'