Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved ProfilerUI here #648

Merged
merged 2 commits into from Dec 20, 2023
Merged

Moved ProfilerUI here #648

merged 2 commits into from Dec 20, 2023

Conversation

JanBliznicenko
Copy link
Contributor

@JanBliznicenko JanBliznicenko commented Dec 14, 2023

Moved ProfilerUI here from Pharo repository. Part of efforts toward resolving issue pharo-project/pharo#15795. Do not merge until pharo-project/pharo#15797 is merged. Once it is, CI needs to be restarted

@jecisc
Copy link
Member

jecisc commented Dec 14, 2023

I probably restarted too soon because we'll need a new build of Pharo before rerunning this one. This means also a PR integrated in Pharo

@JanBliznicenko
Copy link
Contributor Author

JanBliznicenko commented Dec 14, 2023

I probably restarted too soon because we'll need a new build of Pharo before rerunning this one. This means also a PR integrated in Pharo

Yes, First the pharo one (pharo-project/pharo#15797) needs to be approved, then we will need to wait until pharo image is build, and only then this one has any chance to work :)

@jecisc
Copy link
Member

jecisc commented Dec 19, 2023

Let's rerun when the new Pharo image will be available

@JanBliznicenko JanBliznicenko marked this pull request as ready for review December 20, 2023 13:32
@jecisc jecisc closed this Dec 20, 2023
@jecisc jecisc reopened this Dec 20, 2023
@jecisc jecisc merged commit 1feaa53 into pharo-spec:Pharo12 Dec 20, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants