Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add critics on class option #794

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

hernanmd
Copy link
Collaborator

@hernanmd hernanmd commented Jul 8, 2024

Currently, the Calypso browser in Pharo allows users to run critics on a selected class. However, it lacks the functionality to run critics on a specific chosen class (or multiple selected classes). This feature would enhance the browser's capabilities and provide more flexibility for developers when performing code analysis.

The issue is also described in pharo-project/pharo#16863

This PR adds a menu item option in the Refactoring submenu of selected class(es) in Calypso browser.

Hernán Morales Durand added 2 commits July 8, 2024 10:21
… allows get a list of critiques that broken the selected rules in the selected classes.
@hernanmd hernanmd requested a review from Ducasse July 8, 2024 08:48
@hernanmd hernanmd self-assigned this Jul 8, 2024
@hernanmd hernanmd added the enhancement New feature or request label Jul 8, 2024
@hernanmd hernanmd requested a review from jecisc July 15, 2024 18:32
@jecisc jecisc merged commit a3eefab into pharo-spec:Pharo13 Jul 16, 2024
1 of 2 checks passed
@MarcusDenker
Copy link
Contributor

The PR was merged, but the code seems to be not in the image.

I did a PR to remove an Undeclared reference: #799, which is a workaround to get the tests green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants