Merge pull request #1545 from pharo-spec/remove-deprecated-code

Remove deprecated code
pharo-spec · Jun 13, 2024 · 808f4a2 · 808f4a2
2 parents c2683e3 + 06b20fc
commit 808f4a2
Show file tree

Hide file tree

Showing 16 changed files with 3 additions and 847 deletions.
diff --git a/src/Spec2-Core/SpAbstractListPresenter.class.st b/src/Spec2-Core/SpAbstractListPresenter.class.st
@@ -61,28 +61,6 @@ SpAbstractListPresenter >> activateOnSingleClick [
 	activateOnSingleClick := true
 ]
 
-{ #category : 'testing' }
-SpAbstractListPresenter >> activatesOnDoubleClick [
-	"Answer true if activation event is triggered on double click"
-
-	self
-		deprecated: 'Use isActiveOnDoubleClick'
-		transformWith: '`@receiver activatesOnDoubleClick' -> '`@receiver isActiveOnDoubleClick'.
-
-	^ activateOnSingleClick not
-]
-
-{ #category : 'testing' }
-SpAbstractListPresenter >> activatesOnSingleClick [
-	"Answer true if activation event is triggered on single click"
-
-	self
-		deprecated: 'Use isActiveOnSingleClick'
-		transformWith: '`@receiver activatesOnSingleClick' -> '`@receiver isActiveOnSingleClick'.
-
-	^ activateOnSingleClick
-]
-
 { #category : 'api' }
 SpAbstractListPresenter >> beMultipleSelection [
 	"Enable multiple selection."

diff --git a/src/Spec2-Core/SpAbstractTreePresenter.class.st b/src/Spec2-Core/SpAbstractTreePresenter.class.st
@@ -47,28 +47,6 @@ SpAbstractTreePresenter >> activateOnSingleClick [
 	activateOnSingleClick := true
 ]
 
-{ #category : 'testing' }
-SpAbstractTreePresenter >> activatesOnDoubleClick [
-	"Answer true if activation event is triggered on double click"
-
-	self
-		deprecated: 'Use isActiveOnDoubleClick'
-		transformWith: '`@receiver activatesOnDoubleClick' -> '`@receiver isActiveOnDoubleClick'.
-
-	^ activateOnSingleClick not
-]
-
-{ #category : 'testing' }
-SpAbstractTreePresenter >> activatesOnSingleClick [
-	"Answer true if activation event is triggered on single click"
-
-	self
-		deprecated: 'Use isActiveOnSingleClick'
-		transformWith: '`@receiver activatesOnSingleClick' -> '`@receiver isActiveOnSingleClick'.
-
-	^ activateOnSingleClick
-]
-
 { #category : 'api' }
 SpAbstractTreePresenter >> beMultipleSelection [
 	"Enable multiple selection."

diff --git a/src/Spec2-Core/SpApplication.class.st b/src/Spec2-Core/SpApplication.class.st
@@ -117,15 +117,6 @@ SpApplication >> backend [
 		backend ]
 ]
 
-{ #category : 'showing' }
-SpApplication >> close [
-
-	self 
-		deprecated: 'Use #closeAllWindows instead' 
-		transformWith: '`@receiver close' -> '`@receiver closeAllWindows'.
-	self closeAllWindows
-]
-
 { #category : 'accessing' }
 SpApplication >> closeAllWindows [
 

diff --git a/src/Spec2-Core/SpDropListPresenter.class.st b/src/Spec2-Core/SpDropListPresenter.class.st
@@ -163,32 +163,6 @@ SpDropListPresenter >> hasIcons [
 			each icon isNotNil or: [ (self getIconFor: each) isNotNil ] ] ]
 ]
 
-{ #category : 'api' }
-SpDropListPresenter >> iconBlock [ 
-	"Answer the block that will be used to retrieve the icon to be displayed along with the 
-	 elements."
-
-	self 
-		deprecated: 'Please use #displayIcon instead' 
-		transformWith:  '`@receiver iconBlock' 
-						-> '`@receiver displayIcon'.
-
-	^ iconBlock
-]
-
-{ #category : 'api' }
-SpDropListPresenter >> iconBlock: aBlock [	
-	"Answer a block that will be used to retrieve the icon to be displayed along with the elements.
-	 `aBlock` receives one argument (an element from the list)"
-
-	self 
-		deprecated: 'Please use #displayIcon: instead' 
-		transformWith:  '`@receiver iconBlock: `@arg' 
-						-> '`@receiver displayIcon: `@arg'.
-
-	iconBlock := aBlock
-]
-
 { #category : 'initialization' }
 SpDropListPresenter >> initialize [
 	super initialize.

diff --git a/src/Spec2-Core/SpDynamicPresenter.class.st b/src/Spec2-Core/SpDynamicPresenter.class.st
diff --git a/src/Spec2-Core/SpStringTableColumn.class.st b/src/Spec2-Core/SpStringTableColumn.class.st
@@ -125,7 +125,7 @@ SpStringTableColumn >> onAcceptEdition: aBlock [
 	acceptAction := aBlock
 ]
 
-{ #category : #api }
+{ #category : 'api' }
 SpStringTableColumn >> onTextChanged: aBlock [
 	"Set the block to execute when cell edition is edited.
 	 `aBlock` receives two arguments:
@@ -135,7 +135,7 @@ SpStringTableColumn >> onTextChanged: aBlock [
 	textChanged := aBlock
 ]
 
-{ #category : #api }
+{ #category : 'api' }
 SpStringTableColumn >> sortFunction [
 
 	^ super sortFunction ifNil: [ self evaluation ascending ]
@@ -156,7 +156,7 @@ SpStringTableColumn >> sortFunction: aBlockOrSortFunction [
 	self isSortable: aBlockOrSortFunction isNotNil
 ]
 
-{ #category : #accessing }
+{ #category : 'accessing' }
 SpStringTableColumn >> textChanged [
 
 	^ textChanged

diff --git a/src/Spec2-Core/SpTDynamicPresenter.trait.st b/src/Spec2-Core/SpTDynamicPresenter.trait.st
diff --git a/src/Spec2-Core/SpToolbarToggleButtonPresenter.class.st b/src/Spec2-Core/SpToolbarToggleButtonPresenter.class.st
@@ -93,15 +93,6 @@ SpToolbarToggleButtonPresenter >> isSelected [
 	^ self state
 ]
 
-{ #category : 'api' }
-SpToolbarToggleButtonPresenter >> selected: aBoolean [
-
-	self 
-		deprecated: 'Use #state: instead.' 
-		transformWith: '`@receiver selected: `@arg' -> '`@receiver state: `@arg'.  
-	self setSelection: aBoolean
-]
-
 { #category : 'private' }
 SpToolbarToggleButtonPresenter >> setSelection: aBoolean [
 
@@ -157,19 +148,6 @@ SpToolbarToggleButtonPresenter >> whenDeactivatedDo: aBlock [
 		newSelectedValue ifFalse: [ aBlock value ] ]
 ]
 
-{ #category : 'api - events' }
-SpToolbarToggleButtonPresenter >> whenSelectedDo: aBlock [
-	"Inform when the button has been selected. 
-	 `aBlock` receives zero arguments."
-
-	self 
-		deprecated: 'Use #whenActivatedDo: instead.' 
-		transformWith: '`@receiver whenSelectedDo: `@arg' -> '`@receiver whenActivatedDo: `@arg'.  
-
-	self whenChangedDo: [ :newSelectedValue | 
-		newSelectedValue ifTrue: [ aBlock value ] ]
-]
-
 { #category : 'api - events' }
 SpToolbarToggleButtonPresenter >> whenToggledDo: aBlock [ 
 	"Inform when the button has been toggles. 
@@ -180,16 +158,3 @@ SpToolbarToggleButtonPresenter >> whenToggledDo: aBlock [
 
 	self property: #selected whenChangedDo: aBlock 
 ]
-
-{ #category : 'api - events' }
-SpToolbarToggleButtonPresenter >> whenUnselectedDo: aBlock [
-	"Inform when the button has been unselected. 
-	 `aBlock` receives zero arguments."
-
-	self 
-		deprecated: 'Use #whenDeactivatedDo: instead.' 
-		transformWith: '`@receiver whenUnselectedDo: `@arg' -> '`@receiver whenDeactivatedDo: `@arg'.  
-
-	self whenChangedDo: [ :newSelectedValue | 
-		newSelectedValue ifFalse: [ aBlock value ] ]
-]
diff --git a/src/Spec2-Core/SpWindowPresenter.class.st b/src/Spec2-Core/SpWindowPresenter.class.st
@@ -386,17 +386,6 @@ SpWindowPresenter >> isResizable [
 	^ resizable
 ]
 
-{ #category : 'testing' }
-SpWindowPresenter >> isResizeable [
-	"Answer if window is resizeable"
-
-	self 
-		deprecated: 'Use #isResizable instead'  
-		transformWith: '`@receiver isResizeable' -> '`@receiver isResizable'.
-
-	^ self isResizable
-]
-
 { #category : 'testing' }
 SpWindowPresenter >> isTopWindow [
 	"Answer true if this si the active window (the one that has the focus)"

diff --git a/src/Spec2-Dialogs/SpApplication.extension.st b/src/Spec2-Dialogs/SpApplication.extension.st
@@ -80,16 +80,6 @@ SpApplication >> newJobList [
 	^ SpJobListPresenter newApplication: self
 ]
 
-{ #category : '*Spec2-Dialogs' }
-SpApplication >> newProgress [
-
-	self 
-		deprecated: 'Use #newJobList' 
-		transformWith:  '`@receiver newProgress' 
-						-> '`@receiver newJobList'.
-	^ SpJobListPresenter newApplication: self
-]
-
 { #category : '*Spec2-Dialogs' }
 SpApplication >> newRequest [
 

diff --git a/src/Spec2-Interactions/SpInteractionCancelled.class.st b/src/Spec2-Interactions/SpInteractionCancelled.class.st
diff --git a/src/Spec2-Interactions/SpInvalidUserInput.class.st b/src/Spec2-Interactions/SpInvalidUserInput.class.st