Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpCommand>>iconNamed: #23

Closed
Ducasse opened this issue Oct 9, 2019 · 2 comments
Closed

SpCommand>>iconNamed: #23

Ducasse opened this issue Oct 9, 2019 · 2 comments

Comments

@Ducasse
Copy link
Contributor

Ducasse commented Oct 9, 2019 •
edited
Loading

should be categorised as internal.
As a user I should use

icon
iconName:
and
iconProvider

Is it correct?

I would remove iconName:from: because I do not see the advantage of
iconProvider:
iconName:
@juliendelplanque
Copy link
Member

should be categorised as internal.
As a user I should use

icon
iconName:
and
iconProvider

Is it correct?

Yes, I will categorise it as "private".
It is in "accessing" because in Object, this method is in "accessing" protocol.

I would remove iconName:from: because I do not see the advantage of
iconProvider:
iconName:

This is syntax sugar, just makes life of people easier.
But it indeed requires a comment to explain that.

@juliendelplanque
Copy link
Member

Fixed in d97e834 and 1f8dd15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ducasse @juliendelplanque