Skip to content

Commit

Permalink
Fixes #6 - Add abstract class for common test code. - Add IcePackageR…
Browse files Browse the repository at this point in the history
…eference to model packages from our view.
- Differentiate loaded from unloaded packages in a repository.
-
  • Loading branch information
npasserini committed May 25, 2016
1 parent 8a780ab commit 31c50cf
Show file tree
Hide file tree
Showing 31 changed files with 98 additions and 28 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*Iceberg-Core
asIcePackage
^ Ice packageNamed: self asFileReference basenameWithoutExtension
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
{
"name" : "FileSystemDirectoryEntry" }
2 changes: 1 addition & 1 deletion Iceberg.package/Ice.class/class/packageNamed..st
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
accessing
packageNamed: packageName
^ MCPackage named: packageName
^ IcePackageReference named: packageName
5 changes: 0 additions & 5 deletions Iceberg.package/Ice.class/class/packageNamed.ifPresent..st

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions Iceberg.package/Ice.class/class/workingCopyForPackage..st

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
accessing
workingCopyForPackageNamed: packageName
^ self workingCopyForPackage: (self packageNamed: packageName)
^ (self packageNamed: packageName) workingCopy
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ commitWithMessage: commitMessage to: repository
"It should not be necessary to receive the repository as an argument, I should get it
from the package (which should be smarter)"
repository
savePackage: self package name
savePackage: self package packageName
withMessage: commitMessage
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
printing
description
^ self package packageName
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
printing
printOn: aStream
aStream nextPutAll: self package name
aStream nextPutAll: self class name;
nextPut: $(;
nextPutAll: self package packageName;
nextPut: $)
7 changes: 7 additions & 0 deletions Iceberg.package/IcePackageReference.class/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
I represent a package, that could be in an IceRepository or in the image.

Public API and Key Messages
- isLoaded tells if the package is currently loaded in the image.

In the future we should add load/unload here.
We could also add commit, but in general is better to commit at the project level and not at the package level.
5 changes: 5 additions & 0 deletions Iceberg.package/IcePackageReference.class/class/named..st
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
instance creation
named: aPackageName
^ self new
packageName: aPackageName;
yourself
4 changes: 4 additions & 0 deletions Iceberg.package/IcePackageReference.class/instance/^equals.st
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
comparing
= anotherPackage
^ anotherPackage species = self species
and: [ self packageName = anotherPackage packageName ]
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
accessing
isLoaded
^ RPackageOrganizer default includesPackageNamed: packageName
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
accessing
packageName: anObject
packageName := anObject
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
accessing
packageName
^ packageName
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
printing
printOn: aStream
aStream nextPutAll: self class name;
nextPut: $(;
nextPutAll: packageName;
nextPutAll: ', ';
nextPutAll: (self isLoaded ifTrue: 'loaded' ifFalse: 'not loaded');
nextPut: $)

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
querying
workingCopy
^ self isLoaded ifTrue: [
MCWorkingCopy forPackage: (MCPackage named: self packageName)]
14 changes: 14 additions & 0 deletions Iceberg.package/IcePackageReference.class/properties.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"category" : "Iceberg-Core",
"classinstvars" : [
],
"classvars" : [
],
"commentStamp" : "NicoPasserini 5/25/2016 12:00",
"instvars" : [
"packageName" ],
"name" : "IcePackageReference",
"pools" : [
],
"super" : "Object",
"type" : "normal" }
6 changes: 1 addition & 5 deletions Iceberg.package/IceRepository.class/instance/allPackages.st
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
querying
allPackages
^ Array streamContents: [ :result |
self lookupPackages collect: [ :directory |
Ice packageNamed: (directory asFileReference basenameWithoutExtension)
ifPresent: [ :package | result nextPut: package mcPackage ]
]]
^ self lookupPackages collect: #asIcePackage
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ latestVersionForPackage: package
| latest |
latest := versions detectMax: #versionNumber.
repository versionFromFileNamed: latest]
ifEmpty: [ self error: 'Package ', package name, ' is not found in repository ', self ]
ifEmpty: [ self error: 'Package ', package name, ' is not found in repository ', self printString ]
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
working copies
loadedPackages
^ self allPackages filter: #isLoaded
6 changes: 6 additions & 0 deletions Iceberg.package/IceRepository.class/instance/printOn..st
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
printing
printOn: aStream
aStream nextPutAll: self class name;
nextPut: $(;
nextPutAll: self origin url;
nextPut: $)
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
versions handling
versionsFor: package
^ self allVersionDescriptors select: [ :version | version packageName = package name ]
^ self allVersionDescriptors select: [ :version | version packageName = package packageName ]
9 changes: 9 additions & 0 deletions Iceberg.package/IceRepository.class/instance/workingCopies.st
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
working copies
workingCopies
^ self loadedPackages collect: #workingCopy
" ^ Array streamContents: [ :result |
self lookupPackages collect: [ :directory |
Ice packageNamed: (directory asFileReference basenameWithoutExtension)
ifPresent: [ :package | result nextPut: package mcPackage ]
]]
"
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
accessing
package
^ self targetClass package mcPackage
^ Ice packageNamed: self targetClass package name
5 changes: 2 additions & 3 deletions Iceberg.package/IceWorkingCopyDiff.class/instance/changes.st
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ querying
changes
^ changes ifNil: [changes :=
repository allPackages flatCollect: [ :package |
| workingCopy mine theirs patch |
workingCopy := Ice workingCopyForPackage: package.
mine := workingCopy snapshot.
| mine theirs patch |
mine := package workingCopy snapshot.
theirs := (repository latestVersionForPackage: package) snapshot.
patch := MCPatch fromBase: theirs target: mine.
patch operations
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
initialization
repository: aGitRepository
repository := aGitRepository.
list items: ((Ice workingCopiesForRepository: repository)
list items: (repository workingCopies
sorted: [ :a :b | a name < b name ]).
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
*Iceberg
otraPrueba
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
*Iceberg-Core
prueba
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
{
"name" : "ImportingResourceHelp" }

0 comments on commit 31c50cf

Please sign in to comment.