make sure the category is a symbol #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "make sure the category is a symbol" This reverts commit a04178c. maybe this time we only change the line that we want to change
jecisc
approved these changes
Jan 4, 2019
|
in fact, this is the opposite :( with people from Gemstone we agreed to "always use strings, no matter if later they should be symbols". I know, this is still not documented (Martin was working on a spec but is not published yet). I will add a TODO for next week to update the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make sure Tonel writes the category always as a symbol.
It started from the pull request of VMMaker code into opensmalltalk vm where we have commits like: OpenSmalltalk/opensmalltalk-vm@4accb9e.