Rebase onto outrigger/keel #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are all the /etc files for each php version removed? Looks like an oversight/mistake? |
|
I believe those are all common files moved to keel. |
febbraro
approved these changes
Nov 3, 2017
|
While I did some basic testing of this, I did not use it on a real project. Should we publish temporary images and see if we can find folks to test this on a real project? |
The 5.5 image declared 5.6 in it's labels. All label declarations needed the comment about CentOS moved and a slash added to avoid syntax declaration errors trying to build.
|
I did a build and tested the PHP 5.6 image against a project (did a codebase build with it) and things seemed to go well. I pushed commit 8d33480 with things that I found that needed tweaking in order to allow me to build the images successfully and one typo that I found. Thumbs up from me on moving forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible the README could use some additional tuning.
Image Sizes
PHP Version | Before | After
-------------+---------+-------
php71 | 454 MB | ?
php70 | 453 MB | ?
php56 | 446 MB | ?
php55 | 453 MB | ?
Docker Hub has compressed image sizes, but from local builds I can only derive the full size.
Fixes #26