Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 71 (Android) fullscreen mode does not hide Android soft keys #626

Closed
daniel-nth opened this issue Apr 30, 2019 · 4 comments
Closed
Assignees
Milestone

Comments

@daniel-nth
Copy link

You may not notice the issue if your Android device has hardware navigation keys. Pixel phones for example have not. Here's a screenshot of the problem.

This can be solved by passing Fullscreen​Options​.navigationU to the fullscreen request. MDN

I'll send a pull request in the next couple of days.

@daniel-nth
Copy link
Author

Not sure if can test for FullscreenOptions support, but I don't think there's any harm in passing it to browsers that don't support it.

@photonstorm
Copy link
Collaborator

It already passes navigationUI: hide to the fullscreen request, so I don't think it's that.

https://github.com/photonstorm/phaser/blob/master/src/scale/ScaleManager.js#L1181-L1183

@daniel-nth
Copy link
Author

@photonstorm
Copy link
Collaborator

Oops, sorry, yes :) Should be easy enough to add in there.

@samme samme added this to the 2.12.1 milestone Apr 30, 2019
daniel-nth pushed a commit to daniel-nth/phaser-ce that referenced this issue May 2, 2019
daniel-nth pushed a commit to daniel-nth/phaser-ce that referenced this issue May 2, 2019
@samme samme closed this as completed in 16e72c7 May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants