Bugfix: Texture smoothing #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only mark texture as dirty when scaleMode differs from previous value
|
Can you change to |
|
@samme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only mark texture as dirty when scaleMode differs from previous value
This PR (choose one or more, ✏️ delete others)
Please include a summary in Change Log: Unreleased and thank yourself.
Describe the changes below:
Commit 7ea0dd2 a fix for #432 but marks texture always as dirty. Even if the smoothed value doesn't change at all. This fix now checks if the previous value actually differs to current. If it does, it marks the texture as dirty. This fixes some performance regressions for our framework that the commit introduced.