Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definition files has incorrect function signature #2475

Closed
galen-manuel opened this issue May 11, 2016 · 1 comment
Closed

Typescript definition files has incorrect function signature #2475

galen-manuel opened this issue May 11, 2016 · 1 comment

Comments

@galen-manuel
Copy link

This Issue is about

  • An error in the TypeScript defs

Line 8847 in the comments file and line 1638 in the defs file for Group.callAllExists has an incorrect function signature causing a compile error and breaking intellisense when using Typescript.

The callback parameter is of type Function when it should be of type string.

photonstorm added a commit that referenced this issue May 16, 2016
@photonstorm
Copy link
Collaborator

Thanks for submitting this issue. We have fixed this, and the fix has been pushed to the dev branch.

chao-xian added a commit to chao-xian/phaser that referenced this issue Jun 2, 2016
* upstream/master: (990 commits)
  Phaser 2.4.8 release.
  Update Documentation in Game.js
  Sprites that had a tint on them, that then had their frame changed via either `Sprite.frame` or `Sprite.frameName` wouldn't re-tint the new frame, and would become stuck on the old frame in Canvas mode (thaks @spayton phaserjs#2453)
  Sounds played using the Audio tag, set to loop, would get caught in an endless pause-play loop cycle (thanks @rroylance phaserjs#2473)
  Position in Body.reset phaserjs#2470
  Sounds played using the Audio tag, that were paused and then resumed again (either directly in code, or via a game pause event) would not resume from the point at which they paused (thanks @rroylance phaserjs#2473)
  If you set Game.renderType to `Phaser.HEADLESS` it will no longer render the output to the canvas. The canvas is still created (although not added to the DOM), as it's required internally, but no rendering now takes place on it (thanks @ForgeableSum phaserjs#2464)
  Arcade Physics Body has a new property `worldBounce`. This controls the elasticity of the Body specifically when colliding with the World bounds. By default this property is `null`, in which case Body.bounce is used instead. Set this property to a Phaser.Point object in order to enable a World bounds specific bounce value (thanks @VitaZheltyakov phaserjs#2465)
  Fixed a bug in Arcade Physics Body.preUpdate which would incorrectly apply the position of an offset Body (one which has had Body.setSize used on it) when combined with a Sprite with a non-zero anchor (thanks @SBCGames phaserjs#2470)
  Arcade Physics has had a new `world` argument added to the following functions: `distanceBetween`, `distanceToXY`, `distanceToPointer`, `angleBetween`, `angleToXY` and `angleToPointer`. The argument (which is false by default), when enabled will calculate the angles or distances based on the Game Objects `world` property, instead of its `x` and `y` properties. This allows it to work for objects that are placed in offset Groups, or are children of other display objects (thanks @Skeptron for the thread phaserjs#2463)
  TS defs fix phaserjs#2475
  Text.setStyle has a new argument `update` which will optionally automatically call `updateText` after setting the new style (thanks @staff0rd  phaserjs#2478)
  fix generateTexture return type
  BitmapData.copy, and by extension any method that uses it, including BitmapData.draw, drawGroup and drawFull, now all support drawing RenderTexture objects. These can either be passed directly, or be the textures of Sprites, such as from a call to generateTexture.
  Docs update.
  Removed, this has gone to its own branch.
  BitmapData.drawGroupProxy is now capable of iterating through Sprites that have children, and also now uses the world positions for drawing instead.
  Swap to use worldScale instead of worldTransform.
  Revert worldScale setter.
  Typo fix.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants