Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcade.Body#rotation, #preRotation should be initialized from Sprite#angle, not Sprite#rotation #2708

Closed
samme opened this issue Aug 20, 2016 · 2 comments

Comments

@samme
Copy link
Contributor

samme commented Aug 20, 2016

Arcade.Body copies these from sprite.rotation, but that's incorrect.

They should be copied from sprite.angle, as in Arcade.Body#preUpdate.

This Issue is about

  • A bug in the API
photonstorm added a commit that referenced this issue Aug 21, 2016
…ngle instead of sprite.rotation. The property was immediately replaced with the correct value in Body.preUpdate regardless, but it keeps it consistent (thanks @samme #2708)
@photonstorm
Copy link
Collaborator

It doesn't functionally make any difference, as it's replaced immediately via preUpdate anyway, but you're right, it should use that value instead, so I've fixed it in dev.

@samme
Copy link
Contributor Author

samme commented Aug 21, 2016

I figured as much, but thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants