Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer events doesn't emit after scrolled when setting resolution > 1 #3903

Closed
thanh-taro opened this issue Aug 8, 2018 · 9 comments
Closed

Comments

@thanh-taro
Copy link

thanh-taro commented Aug 8, 2018

Hello,

I'm really happy after Phaser 3.12-beta1 was released. It helps me fixed many issues which made me stuck for weeks. 馃挴 馃憤

But today, I figure out there are some issues in pointers and pointers's events when setting resolution > 1.

  1. After the game scrolled (long distance), the pointer did not emit events (pointerdown, pointerup and pointerout) correctly. I think it is because of checking wrong position of Game Objects, so the game thinks that user doesn't point to the target Object => doesn't emit events.

  2. The pointerout event doesn't emit on touchable devices. You can use Google Chrome, open Developer menu and switch to a mobile device, then you'll see. But it works fine in Desktop Browsers.

It seems that setting resolution by now isn't a good idea, there are many issues with it.

You can write a simple game with tilemap and touch buttons (to scroll the game) to verify these issues.
I made a simple project with Phaser 3.12-beta1 to test, if you need, I'll give you a zip file through your email.

Hope it will be fixed soon before v3.12 is released. Thank you.

@photonstorm
Copy link
Collaborator

The pointerout and pointerover events are not dispatched for Touch pointers and never have been. This isn't resolution related, it's done on purpose and won't change in 3.12.

I'll look into the resolution + camera scroll issue.

@thanh-taro
Copy link
Author

Oh really. I missed that point. I think it's good if there are some lines in the document.
Hope to see your feedback about the resolution and camera scroll issue soon. Thank you so much.

@thanh-taro
Copy link
Author

About this issue, how is it going?

@thanh-taro
Copy link
Author

In the latest release, it is no longer to click on object when world size is bigger than game size (and resolution > 1 of course).

@photonstorm
Copy link
Collaborator

This isn't fixed in beta 3 yet. Will be for beta 4 when the scale manager is finished.

@photonstorm
Copy link
Collaborator

(hence why this issue is still open)

@photonstorm
Copy link
Collaborator

This is now fixed in the master branch. I created a huge game world (40k x 40k) and placed 2k objects in it, and I could click them all, scrolling around happily, no matter what resolution was set. Previously, it only worked with a resolution of 1.

@thanh-taro
Copy link
Author

Phaser 3.12.0 is released. I confirm that the issue is fixed.
Nice guys!

@photonstorm
Copy link
Collaborator

Unfortunately: #4010 - I knew about this, but couldn't hold off 3.12 any longer, so will resolve it as part of the next round of updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants