Negative lineSpacing shouldn't crop text #2379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.4.6 introduced a change to the way line height is calculated. This caused negative lineSpacing to have cropped text. I added a conditional to handle negative line spacing while still honoring the new calculation for positive lineSpacing.
|
I couldn't merge your PR because of conflicts, but have added your change locally, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.4.6 introduced a change to the way line height is calculated. This caused negative lineSpacing to have cropped text. I added a conditional to handle negative line spacing while still honoring the new calculation for positive lineSpacing. I reported the issue as #2374.
Example of bug:
Example code:
cropped-text.zip