Fix #5828, improve GameObject#disableInteractive() and InputPlugin#disable() #5839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natureofcode
commented
Sep 17, 2021
| this._temp.splice(index, 1); | ||
| } | ||
|
|
||
| for (var i = 0; i < 10; i++) |
There was a problem hiding this comment.
Maybe change to for (var i = 0; i < this.manager.pointersTotal; i++) for possible optimization?
|
|
photonstorm
added a commit
that referenced
this pull request
Dec 1, 2021
…urn if input false, as object may still be in arrays anyway #5839
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
Changed the
GameObject.disableInteractive()method behavior to be more similar to theGameObject.removeInteractive().Now, when
GameObject.disableInteractive()orInputPlugin.disable(gameObject)is called,gameObjectis being immediately removed from the sensitive temporary arrays involved in event processing.Another possible solution is to revise the internal logic of
InputPluginclass event processing procedures, changingif (input) { /* FIRE EVENT */ }checks toif (input && input.enabled).Everyone can test this PR in the updated CodeSandbox
Resolves #5828