Web audio external node fix #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I'm in two minds about this one - because it's possible to use it both ways. However relying on AudioNode.input isn't actually correct as it's not a valid property, so I'm going to merge your change and stick it into the docs in case anyone was using the old format. |
photonstorm
added a commit
that referenced
this pull request
Jul 1, 2014
Web audio external node fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had troubles connecting to an external audio node (Web Audio API). It was giving this error
By changing the Sound.play and Sound.resume functions to connect to the externalNode instead of externalNode.input seemed to fix these problems.