Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing missing Layout through indexer off of Select applicative throwing ValueMissingException #69

Closed
ahives opened this issue Oct 28, 2018 · 4 comments

Comments

@ahives
Copy link
Contributor

ahives commented Oct 28, 2018

Accessing missing Layout through indexer off of Select applicative throwing ValueMissingException

var patientControlNumber = transactions
                .Select(x => x.PatientDetail)[0]
                .Select(x => x.PayerClaimControlNumber)[0]
                .Select(x => x.PatientControlNumber)
                .Select(x => x.ReferenceIdentificationQualifier);

If PatientDetail/PayerClaimControlNumber this will blow up and it shouldn't.

@ahives ahives changed the title Accessing missing Layout throwing ValueMissingException Accessing missing Layout through indexer off of Select applicative throwing ValueMissingException Oct 28, 2018
@ahives
Copy link
Contributor Author

ahives commented Oct 28, 2018

This will be fixed in next commit

@phatboyg
Copy link
Owner

Why wouldn't this blow up? You're accessing the first element of an empty list.

ahives added a commit to ahives/Machete that referenced this issue Oct 29, 2018
@ahives
Copy link
Contributor Author

ahives commented Oct 29, 2018

I think I didn't explain this correctly. I meant to say that I have changed MissingLayoutList to the same pattern as MissingValueList.

But to answer your question it will blow up if I were to do something like...

var patientControlNumber = transactions
                .Select(x => x.PatientDetail)[0]
                .Select(x => x.PayerClaimControlNumber)[0].Value;

Our current pattern is not to blow up on this...

var patientControlNumber = transactions
                .Select(x => x.PatientDetail)[0]
                .Select(x => x.PayerClaimControlNumber)[0];

This will be fixed for both MissingSegmentList and MissingLayoutList.

ahives added a commit to ahives/Machete that referenced this issue Dec 16, 2018
fixed test issue

add more conditions to X12 maps

added conditional logic to several X12 maps

created more conditions in maps and created failing unit test for issue phatboyg#65

added new failing test for issue phatboyg#65

updated readme and added tests for issue phatboyg#65

fixed gitter link

added appveyor badge

added nuget version badge

added appveyor test status badge

added appveyor test status badge

added appveyor test status badge

modified the readme

added license section to readme

modified readme

added more stuff to readme

modified readme

modified readme

modified readme and tests

updated tests and readme

added tests for X12

added more X12 tests

fixed issue phatboyg#68 and added tests

fixed issue phatboyg#69 and added more X12 parsing tests

added more tests and fixed some X12 schema issues
ahives added a commit to ahives/Machete that referenced this issue Dec 16, 2018
fixed test issue

add more conditions to X12 maps

added conditional logic to several X12 maps

created more conditions in maps and created failing unit test for issue phatboyg#65

added new failing test for issue phatboyg#65

updated readme and added tests for issue phatboyg#65

fixed gitter link

added appveyor badge

added nuget version badge

added appveyor test status badge

added appveyor test status badge

added appveyor test status badge

modified the readme

added license section to readme

modified readme

added more stuff to readme

modified readme

modified readme

modified readme and tests

updated tests and readme

added tests for X12

added more X12 tests

fixed issue phatboyg#68 and added tests

fixed issue phatboyg#69 and added more X12 parsing tests

added more tests and fixed some X12 schema issues

modified X12 schema and added several tests

added more X12 tests

added more X12 parser tests

made some changes to HL7 schema

fixed issue phatboyg#70

added X12 tests and fixed issue phatboyg#68 for both HL7 and X12

added more X12 tests

made some schema changes and added some tests
phatboyg pushed a commit to MassTransit/Machete that referenced this issue Dec 16, 2018
fixed test issue

add more conditions to X12 maps

added conditional logic to several X12 maps

created more conditions in maps and created failing unit test for issue phatboyg#65

added new failing test for issue phatboyg#65

updated readme and added tests for issue phatboyg#65

fixed gitter link

added appveyor badge

added nuget version badge

added appveyor test status badge

added appveyor test status badge

added appveyor test status badge

modified the readme

added license section to readme

modified readme

added more stuff to readme

modified readme

modified readme

modified readme and tests

updated tests and readme

added tests for X12

added more X12 tests

fixed issue phatboyg#68 and added tests

fixed issue phatboyg#69 and added more X12 parsing tests

added more tests and fixed some X12 schema issues

modified X12 schema and added several tests

added more X12 tests

added more X12 parser tests

made some changes to HL7 schema

fixed issue phatboyg#70

added X12 tests and fixed issue phatboyg#68 for both HL7 and X12

added more X12 tests

made some schema changes and added some tests
@ahives
Copy link
Contributor Author

ahives commented Dec 23, 2018

this is fixed as of v1.0.245-develop

@ahives ahives closed this as completed Dec 23, 2018
phatboyg pushed a commit that referenced this issue May 23, 2020
fixed test issue

add more conditions to X12 maps

added conditional logic to several X12 maps

created more conditions in maps and created failing unit test for issue #65

added new failing test for issue #65

updated readme and added tests for issue #65

fixed gitter link

added appveyor badge

added nuget version badge

added appveyor test status badge

added appveyor test status badge

added appveyor test status badge

modified the readme

added license section to readme

modified readme

added more stuff to readme

modified readme

modified readme

modified readme and tests

updated tests and readme

added tests for X12

added more X12 tests

fixed issue #68 and added tests

fixed issue #69 and added more X12 parsing tests

added more tests and fixed some X12 schema issues

modified X12 schema and added several tests

added more X12 tests

added more X12 parser tests

made some changes to HL7 schema

fixed issue #70

added X12 tests and fixed issue #68 for both HL7 and X12

added more X12 tests

made some schema changes and added some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants