Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need clarification regarding mdnoptions - signed/unsigned mdn #56

Closed
ihudedi opened this issue Aug 27, 2018 · 9 comments
Closed

Need clarification regarding mdnoptions - signed/unsigned mdn #56

ihudedi opened this issue Aug 27, 2018 · 9 comments
Assignees
Milestone

Comments

@ihudedi
Copy link

ihudedi commented Aug 27, 2018

Hi Philip,
I would like to know what the correct value for mdnoptions when mdn needs to be signed and not signed.
In my code when mdn not signed I set the protocol algorithm to null and set protocol imprtance and mic algorithm importance to optional while in signed mdn I set all importance to required and set the protocol algorithm.
Is it the correct behaviour?
Thanks,
Itay

@phax phax self-assigned this Aug 27, 2018
@phax phax added the question label Aug 27, 2018
phax added a commit that referenced this issue Aug 27, 2018
@phax
Copy link
Owner

phax commented Aug 27, 2018

Hi. Calling setMDNOptions ("") should do the trick. But this requires the latest SNAPSHOT (see commit above). If you don't have further questions, I would start building 4.2.0-RC1 now.

@phax phax closed this as completed Aug 27, 2018
@ihudedi
Copy link
Author

ihudedi commented Aug 27, 2018

I didn't understand this solution is for unsigned mdn? Can we send null in mdnoptions for unsigned mdn and for not requested mdn?

@phax
Copy link
Owner

phax commented Aug 27, 2018

No, when sending null it falls back to the default (signed, SHA1).
You need to explicit send "" to state: don't use default.... It's a legacy default.

@ihudedi
Copy link
Author

ihudedi commented Aug 27, 2018

I meant setting null in as2clientsetting.setmdnoptions((String)null)

@ihudedi
Copy link
Author

ihudedi commented Aug 27, 2018

I didn't understand.for not requested mdn I set null and for unsigned I set "".?

@phax phax reopened this Aug 27, 2018
@phax
Copy link
Owner

phax commented Aug 27, 2018

To overall request and MDN or not, you use the method setMDNRequested (boolean) from the AS2ClientSettings class.
By default the requested MDN is signed. To disable this signing use setMDNOptions ("").
Ok?

@ihudedi
Copy link
Author

ihudedi commented Aug 27, 2018

If I set to null is it also fine? For not sending mdn do i need to set the mdniptions too?

@phax
Copy link
Owner

phax commented Aug 27, 2018

Okay, I modified the implementation, so that MDNOptions can also be null :)

@ihudedi
Copy link
Author

ihudedi commented Aug 27, 2018

10x:)

@phax phax added enhancement and removed question labels Aug 27, 2018
@phax phax added this to the 4.2.0 milestone Aug 27, 2018
@phax phax closed this as completed Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants