Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync mdn - if mic isn't matched excetiopn isn't thrown #59

Closed
ihudedi opened this issue Aug 27, 2018 · 4 comments
Closed

Sync mdn - if mic isn't matched excetiopn isn't thrown #59

ihudedi opened this issue Aug 27, 2018 · 4 comments
Assignees

Comments

@ihudedi
Copy link

ihudedi commented Aug 27, 2018

Hi Philip,
When working with sync mdn and the mic that returned from the server doesn't match the mic calculated in the client the as2 lib only print that the mic isn't matched without throwing exception.
Is it desired behaviour?
Thanks,
Itay

@phax phax self-assigned this Aug 27, 2018
@phax
Copy link
Owner

phax commented Aug 27, 2018

Yes it is.
Basically because there a lot of different algorithms out there.
But maybe a callback handler to handle "MIC not matched" would potentially make sense :)

@ihudedi
Copy link
Author

ihudedi commented Aug 27, 2018

But in async mdn if mic isnt matched you return false for the checking

@stale
Copy link

stale bot commented May 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 14, 2019
@phax phax added pinned and removed wontfix labels May 15, 2019
phax added a commit that referenced this issue May 27, 2019
@phax
Copy link
Owner

phax commented May 27, 2019

Finally a new interface IMICMatchingHandler that can be used to customize the MIC match and mismatch handling; part of 4.4.0 release

@phax phax closed this as completed May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants