Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MAVEN build Performance #125

Closed
wants to merge 1 commit into from

Conversation

ChenZhangg
Copy link

Parallel builds in Maven 3 Maven 3.x has the capability to perform parallel builds.

Apache Maven Dependency Plugin can be used to find unused dependencies. And I found following list. Maybe we can remove them.
as2-lib-parent-pom
as2-lib
{groupId='org.slf4j', artifactId='slf4j-simple', version='1.7.30', scope='test'}
as2-partnership-mongodb
{groupId='org.slf4j', artifactId='slf4j-simple', version='1.7.30', scope='test'}
as2-servlet
{groupId='org.slf4j', artifactId='slf4j-simple', version='1.7.30', scope='test'}
as2-demo-webapp
{groupId='org.slf4j', artifactId='slf4j-simple', version='1.7.30', scope='compile'}
{groupId='com.sun.xml.bind', artifactId='jaxb-impl', version='2.3.3', scope='compile'}
{groupId='javax.servlet', artifactId='javax.servlet-api', version='3.1.0', scope='provided'}
as2-server
{groupId='org.slf4j', artifactId='jul-to-slf4j', version='1.7.30', scope='compile'}
{groupId='org.apache.logging.log4j', artifactId='log4j-core', version='2.14.1', scope='compile'}
{groupId='org.apache.logging.log4j', artifactId='log4j-slf4j-impl', version='2.14.1', scope='compile'}
{groupId='com.sun.xml.bind', artifactId='jaxb-impl', version='2.3.3', scope='compile'}
as2-demo-spring-boot
{groupId='org.springframework.boot', artifactId='spring-boot-starter-web', version='2.5.3', scope='compile'}
{groupId='com.sun.xml.bind', artifactId='jaxb-impl', version='2.3.3', scope='compile'}
{groupId='org.springframework.boot', artifactId='spring-boot-starter-test', version='2.5.3', scope='test'}
{groupId='org.slf4j', artifactId='slf4j-api', version='1.7.30', scope='compile'}

=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

@phax
Copy link
Owner

phax commented Aug 23, 2021

Hi @ChenZhangg thanks for your PR, but I will not merge it:

  • Travis stopped playing nice with OSS projects and they don't give away continuous "credits" - so this is no longer used.
  • For the other artefacts: all of them are included via SPI or Reflection, so there is no hard coded dependency. All of them are indeed needed. Have you removed them and run the web application e.g.?

@ChenZhangg
Copy link
Author

I just run dependency:analyze command and thought some dependencies are forgotten to be removed.
The Apache Maven Dependency Plugin still need to be improved.......

@phax
Copy link
Owner

phax commented Aug 23, 2021

Well, I guess this is something the Maven Dependency plugin can never solve, because the dependencies via Reflection are more or less impossible to find, except you execute the code....

@phax phax closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants