No assertions for pdfs created during tests?

[Lolf1010]

Hey,
found your library a couple days ago and have been playing with it a bit. Works great.
At work we are currently looking into generating pdf-files that could include tables and came across your library.
Among the few libraries out there, yours seems to be more actively developed / maintained.

I noticed, if i understand the code correctly, that there are no "real" tests for pdf-files that are created during tests.
I only see that the pdf-files are saved but no assertions are performed on it.

If thats not the case then feel free to close this issue.
If it is the case, why and does that mean that you test the pdfs manually?

Thanks

[phax]

Hi @Lolf1010 , yes you are right, I don't really do assertions on them but really do a visual comparison on what I expect them to look. What kind of assertions would you have thought of? Something like

• Number of pages
• When page is extracted as text, it must contain this and that substring
  ? I must admit my creativity on that point is quite limited ;-) Any input is welcome

[Lolf1010]

No worries
Browsing through a couple of libraries i found https://github.com/red6/pdfcompare
Compares the pdfs pixel-by-pixel - seems to make the most sense to compare tables, boxes, images etc within the pdf
Never tried it myself though

[phax]

Thanks, that looks interesting - I will investigate it

[Lolf1010]

Cool.

Final question: In general, do you consider this library stable enough to be used in other projects? Like i wrote in the first comment i am looking at pdf-libraries to help with generating pdf-files. Your library looks awesome. However usually we are using libraries from Apache or known organisations. That why i am asking ;)

[phax]

The library was primarily created to look boring business documents like invoices etc. So the library does not provide fancy stuff like inline formatting or the like, and as a one-person show, I don't have the possibility to create huge functionalities in a short time.

This library is definitively stable enough for production usage and is used for more then 10 years in some governmental applications in Austria to render electronic invoices etc. If you like, I can provide you with access to a Slack channel where you can reach me directly. If so, write me an email to the email address you find in the pom.xml.
hth

[phax]

Most of the files were identical to the "stored one". However, some file files were different by 1 or 2 pixels. One file contains random content, which was chaged to constant content now. So result is a bit more predictable - thanks for pointing this out!