Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PMode class static #41

Closed
phax opened this issue Sep 10, 2020 · 1 comment
Closed

Make PMode class static #41

phax opened this issue Sep 10, 2020 · 1 comment
Assignees

Comments

@phax
Copy link
Owner

phax commented Sep 10, 2020

Thanks Philip. FWIW, I think that it would be best if the PMode class and all of its subclasses were to be concrete. The reason I say this that PModes are something that we want to marshal/demarshal (serialize/deserialze). We want to store them on the file system, in databases, we want to pass them on Kafka streams and MQ queues, etc. Each of the ways that we want to store and/or transport PModes has well known utilities that can directly operate on concrete objects and marshal/demarshal (serialize/deserialze) them. Jackson data-bind, GSON, JAXB, JDBC, Java serialization, etc. If the class and/or its subclasses are not concrete, then it is more complicated and non-standard.

@phax phax self-assigned this Sep 10, 2020
phax added a commit that referenced this issue Sep 20, 2020
@phax
Copy link
Owner Author

phax commented Sep 20, 2020

Part of 0.12.0

@phax phax closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant