Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict requirements for old version of numpy? #43

Closed
russellsmithies opened this issue Aug 23, 2018 · 4 comments
Closed

Strict requirements for old version of numpy? #43

russellsmithies opened this issue Aug 23, 2018 · 4 comments

Comments

@russellsmithies
Copy link

We're having problems with the strict requirement for an old version of numpy ('numpy<1.12.0,>=1.11.0' ) that prevents many other applications running (eg srst2, snapperdb etc). Do you actually need such an old version of numpy or could you manage with the current? The alternative is we stop using PHEnix :-(

@tseemann
Copy link

tseemann commented Aug 25, 2018

Russel, i am not an author of PHEnix but you have a few options.

  1. Use virtualenv, pyenv etc to have separate environments for each big app

  2. After you git clone PHEnix, just edit the requirements.txt file and change the numpy line. eg. https://github.com/phe-bioinformatics/PHEnix/blob/master/requirements.txt and see if it works!

  3. Try an alternative SNP caller, for example

@Wang-Jing-NZ
Copy link

Thank you, Torsten, for your reply. I will try to snippy and GATK outputs first.

Cheers
Jing

@ulfschaefer
Copy link
Contributor

Before you abandon the goodness that is PHEnix for brighter shores ...

This is a case of not tidying up. The requirement for numpy can be removed. The code used to call mean and std from numpy, but it does not appear to do so any more.

68d35c2

And sorry for the late reply. Let me know if you have any problems with this. I will reply faster now.

@russellsmithies
Copy link
Author

All sorted now I think, we'll do a bit more testing to confirm :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants