New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Add support for reserve-job. Added in beanstalkd 1.12+ #222
Conversation
Shouldn't we throw an exception? Returning null is not optimal for use cases where you reasonably expect it to return a value. |
I have no strong opinion on this, happy to change :) |
Let me have a look tomorrow, will get back to you! |
- Throw an Unknown Command exception for older versions
Actually, I like that idea. Also re-throwing an Unknown Command for older versions seems right |
What happens if the response is not found? Also there seem to be no tests included. |
What's happening with this? I've forked the repository specifically to merge in and use this feature. I'd rather move back to yours, though. |
Apologies, shifting priorities, I'll try to plan some time for this soon |
Cool. If it helps, we've been using it in production without making any changes besides what's already in this PR. Thanks for your work! |
I'm merging this, but it will only be available in the next major version of this library, just an FYI. |
Before 1.12, we'll return null if this isn't supported.
Fixes #221