Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#8] Update PhpStan to version 1 and level 9 #9

Merged
merged 1 commit into from Nov 3, 2021
Merged

[#8] Update PhpStan to version 1 and level 9 #9

merged 1 commit into from Nov 3, 2021

Conversation

kpicaza
Copy link
Member

@kpicaza kpicaza commented Nov 3, 2021

Closes #8

@kpicaza kpicaza added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 3, 2021
xserrat
xserrat approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@xserrat xserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

infection.log Outdated
@@ -0,0 +1,161 @@
Escaped mutants:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should commit this file. What do you think?

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kpicaza kpicaza merged commit 5a39aba into 1.0.x Nov 3, 2021
@kpicaza kpicaza deleted the issue#8 branch November 3, 2021 21:47
@kpicaza kpicaza restored the issue#8 branch November 3, 2021 21:47
@kpicaza kpicaza deleted the issue#8 branch November 3, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xserrat xserrat xserrat approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[php-sdk] Update PhpStan to version 1 and level 9
2 participants
@kpicaza @xserrat