[#178] Add ToggleAPIPassTest

pheature-flags · May 23, 2021 · c19ecc0 · c19ecc0
1 parent e5e1d13
commit c19ecc0
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 17 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -6,7 +6,7 @@
     </include>
   </coverage>
   <testsuites>
-    <testsuite name="Antidot\\Tests">
+    <testsuite name="Pheature\\Test\\Crud\\Psr11">
       <directory>./test</directory>
     </testsuite>
   </testsuites>

diff --git a/src/ToggleConfig.php b/src/ToggleConfig.php
@@ -9,7 +9,7 @@
 final class ToggleConfig
 {
     private string $driver;
-    private string $prefix;
+    private string $apiPrefix;
     /** @var array<string, mixed> */
     private array $toggles = [];
 
@@ -18,11 +18,11 @@ final class ToggleConfig
      */
     public function __construct(array $config)
     {
-        Assert::keyExists($config, 'prefix');
+        Assert::keyExists($config, 'api_prefix');
         Assert::keyExists($config, 'driver');
-        Assert::string($config['prefix']);
+        Assert::string($config['api_prefix']);
         Assert::string($config['driver']);
-        $this->prefix = $config['prefix'];
+        $this->apiPrefix = $config['api_prefix'];
         $this->driver = $config['driver'];
         if (array_key_exists('toggles', $config)) {
             Assert::isArray($config['toggles']);
@@ -32,9 +32,9 @@ public function __construct(array $config)
         }
     }
 
-    public function prefix(): string
+    public function apiPrefix(): string
     {
-        return $this->prefix;
+        return $this->apiPrefix;
     }
 
     public function driver(): string

diff --git a/test/FeatureFinderFactoryTest.php b/test/FeatureFinderFactoryTest.php
@@ -25,7 +25,7 @@ public function testItShouldThrowAnExceptionWhenItCantCreateAFeatureFinder(): vo
             $this->createMock(SegmentFactory::class),
             $this->createMock(ToggleStrategyFactory::class),
         );
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'some_other']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'some_other']);
 
         $container->expects(self::exactly(3))
             ->method('get')
@@ -41,7 +41,7 @@ public function testItShouldThrowAnExceptionWhenItCantCreateAFeatureFinder(): vo
     public function testItShouldCreateADBalFeatureFinderFromInvokable(): void
     {
         $container = $this->createMock(ContainerInterface::class);
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'dbal']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'dbal']);
         $chainStrategyFactory = new ChainToggleStrategyFactory(
             $this->createMock(SegmentFactory::class),
             $this->createMock(ToggleStrategyFactory::class),
@@ -62,7 +62,7 @@ public function testItShouldCreateADBalFeatureFinderFromInvokable(): void
     public function testItShouldCreateAnInMemoryFeatureFinderFromInvokable(): void
     {
         $container = $this->createMock(ContainerInterface::class);
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'inmemory']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'inmemory']);
         $chainStrategyFactory = new ChainToggleStrategyFactory(
             $this->createMock(SegmentFactory::class),
             $this->createMock(ToggleStrategyFactory::class),
@@ -81,7 +81,7 @@ public function testItShouldCreateAnInMemoryFeatureFinderFromInvokable(): void
 
     public function testItShouldCreateADBalFeatureFinderFromCreate(): void
     {
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'dbal']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'dbal']);
         $chainStrategyFactory = new ChainToggleStrategyFactory(
             $this->createMock(SegmentFactory::class),
             $this->createMock(ToggleStrategyFactory::class),
@@ -93,7 +93,7 @@ public function testItShouldCreateADBalFeatureFinderFromCreate(): void
 
     public function testItShouldCreateInMemoryFeatureFinderFromCreate(): void
     {
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'inmemory']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'inmemory']);
         $chainStrategyFactory = new ChainToggleStrategyFactory(
             $this->createMock(SegmentFactory::class),
             $this->createMock(ToggleStrategyFactory::class),

diff --git a/test/FeatureRepositoryFactoryTest.php b/test/FeatureRepositoryFactoryTest.php
@@ -21,7 +21,7 @@ public function testItShouldThrowAnExceptionWhenItCantCreateAFeatureRepository()
     {
         $this->expectException(InvalidArgumentException::class);
         $container = $this->createMock(ContainerInterface::class);
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'some_other']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'some_other']);
 
         $container->expects(self::exactly(2))
             ->method('get')
@@ -36,7 +36,7 @@ public function testItShouldThrowAnExceptionWhenItCantCreateAFeatureRepository()
     public function testItShouldCreateADBalFeatureRepositoryFromInvokable(): void
     {
         $container = $this->createMock(ContainerInterface::class);
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'dbal']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'dbal']);
         $connection = $this->createMock(Connection::class);
 
         $container->expects(static::exactly(2))
@@ -53,7 +53,7 @@ public function testItShouldCreateADBalFeatureRepositoryFromInvokable(): void
     public function testItShouldCreateAnInMemoryFeatureRepositoryFromInvokable(): void
     {
         $container = $this->createMock(ContainerInterface::class);
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'inmemory']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'inmemory']);
 
         $container->expects(static::exactly(2))
             ->method('get')
@@ -68,15 +68,15 @@ public function testItShouldCreateAnInMemoryFeatureRepositoryFromInvokable(): vo
 
     public function testItShouldCreateADBalFeatureRepositoryFromCreate(): void
     {
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'dbal']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'dbal']);
         $connection = $this->createMock(Connection::class);
         $featureRepository = FeatureRepositoryFactory::create($toggleConfig, $connection);
         self::assertInstanceOf(FeatureRepository::class, $featureRepository);
     }
 
     public function testItShouldCreateInMemoryFeatureRepositoryFromCreate(): void
     {
-        $toggleConfig = new ToggleConfig(['prefix' => '', 'driver' => 'inmemory']);
+        $toggleConfig = new ToggleConfig(['api_prefix' => '', 'driver' => 'inmemory']);
         $connection = null;
         $featureRepository = FeatureRepositoryFactory::create($toggleConfig, $connection);
         self::assertInstanceOf(FeatureRepository::class, $featureRepository);