add remove strategy use case

src/Command/RemoveStrategy.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Pheature\Crud\Toggle\Command;
+
+use Pheature\Core\Toggle\Write\FeatureId;
+use Pheature\Core\Toggle\Write\StrategyId;
+
+final class RemoveStrategy
+{
+    private FeatureId $featureId;
+    private StrategyId $strategyId;
+
+    private function __construct(string $featureId, string $strategyId)
+    {
+        $this->featureId = FeatureId::fromString($featureId);
+        $this->strategyId = StrategyId::fromString($strategyId);
+    }
+
+    public static function withFeatureAndStrategyId(string $featureId, string $strategyId): self
+    {
+        return new self($featureId, $strategyId);
+    }
+
+    public function featureId(): FeatureId
+    {
+        return $this->featureId;
+    }
+
+    public function strategyId(): StrategyId
+    {
+        return $this->strategyId;
+    }
+}

src/Handler/AddStrategy.php

@@ -5,26 +5,24 @@
 namespace Pheature\Crud\Toggle\Handler;
 
 use Pheature\Core\Toggle\Write\FeatureRepository;
-use Pheature\Core\Toggle\Write\StrategyFactory;
+use Pheature\Core\Toggle\Write\Strategy;
 use Pheature\Crud\Toggle\Command\AddStrategy as AddStrategyCommand;
 
 final class AddStrategy
 {
     private FeatureRepository $featureRepository;
-    private StrategyFactory $strategyFactory;
 
-    public function __construct(FeatureRepository $featureRepository, StrategyFactory $strategyFactory)
+    public function __construct(FeatureRepository $featureRepository)
     {
         $this->featureRepository = $featureRepository;
-        $this->strategyFactory = $strategyFactory;
     }
 
     public function handle(AddStrategyCommand $command): void
     {
         $feature = $this->featureRepository->get($command->featureId());
 
         $feature->addStrategy(
-            $this->strategyFactory->makeFromType($command->strategyId(), $command->strategyType())
+            new Strategy($command->strategyId(), $command->strategyType())
         );
 
         $this->featureRepository->save($feature);

src/Handler/CreateFeature.php

@@ -4,9 +4,9 @@
 
 namespace Pheature\Crud\Toggle\Handler;
 
+use Pheature\Core\Toggle\Write\Feature;
 use Pheature\Core\Toggle\Write\FeatureRepository;
 use Pheature\Crud\Toggle\Command\CreateFeature as CreateFeatureCommand;
-use Pheature\Crud\Toggle\Model\Feature;
 
 final class CreateFeature
 {

src/Handler/RemoveStrategy.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Pheature\Crud\Toggle\Handler;
+
+use Pheature\Core\Toggle\Write\FeatureRepository;
+use Pheature\Crud\Toggle\Command\RemoveStrategy as RemoveStrategyCommand;
+
+final class RemoveStrategy
+{
+    private FeatureRepository $featureRepository;
+
+    public function __construct(FeatureRepository $featureRepository)
+    {
+        $this->featureRepository = $featureRepository;
+    }
+
+    public function handle(RemoveStrategyCommand $command): void
+    {
+        $feature = $this->featureRepository->get($command->featureId());
+
+        $feature->removeStrategy($command->strategyId());
+
+        $this->featureRepository->save($feature);
+    }
+}

test/Handler/AddStrategyTest.php

@@ -5,12 +5,9 @@
 namespace Pheature\Test\Crud\Toggle\Handler;
 
 use Pheature\Core\Toggle\Write\FeatureRepository;
-use Pheature\Core\Toggle\Write\StrategyFactory;
-use Pheature\Core\Toggle\Write\StrategyId;
-use Pheature\Core\Toggle\Write\StrategyType;
 use Pheature\Crud\Toggle\Command\AddStrategy as AddStrategyCommand;
 use Pheature\Crud\Toggle\Handler\AddStrategy;
-use Pheature\Crud\Toggle\Model\Feature;
+use Pheature\Core\Toggle\Write\Feature;
 use Pheature\Core\Toggle\Write\FeatureId;
 use PHPUnit\Framework\TestCase;
 
@@ -32,15 +29,8 @@ public function testItShouldAddStrategyToAFeature(): void
         $repository->expects($this->once())
             ->method('save')
             ->with($feature);
-        $strategyFactory = $this->createMock(StrategyFactory::class);
-        $strategyFactory->expects($this->once())
-            ->method('makeFromType')
-            ->with(
-                $this->isInstanceOf(StrategyId::class),
-                $this->isInstanceOf(StrategyType::class)
-            );
 
-        $handler = new AddStrategy($repository, $strategyFactory);
+        $handler = new AddStrategy($repository);
         $handler->handle($command);
 
         $strategies = $feature->strategies();

test/Handler/CreateFeatureTest.php

@@ -4,10 +4,10 @@
 
 namespace Pheature\Test\Crud\Toggle\Handler;
 
+use Pheature\Core\Toggle\Write\Feature;
 use Pheature\Core\Toggle\Write\FeatureRepository;
 use Pheature\Crud\Toggle\Command\CreateFeature as CreateFeatureCommand;
 use Pheature\Crud\Toggle\Handler\CreateFeature;
-use Pheature\Crud\Toggle\Model\Feature;
 use PHPUnit\Framework\TestCase;
 
 final class CreateFeatureTest extends TestCase

test/Handler/DisableFeatureTest.php

@@ -7,7 +7,7 @@
 use Pheature\Core\Toggle\Write\FeatureRepository;
 use Pheature\Crud\Toggle\Command\DisableFeature as DisableFeatureCommand;
 use Pheature\Crud\Toggle\Handler\DisableFeature;
-use Pheature\Crud\Toggle\Model\Feature;
+use Pheature\Core\Toggle\Write\Feature;
 use Pheature\Core\Toggle\Write\FeatureId;
 use PHPUnit\Framework\TestCase;
 

test/Handler/EnableFeatureTest.php

@@ -7,7 +7,7 @@
 use Pheature\Core\Toggle\Write\FeatureRepository;
 use Pheature\Crud\Toggle\Command\EnableFeature as EnableFeatureCommand;
 use Pheature\Crud\Toggle\Handler\EnableFeature;
-use Pheature\Crud\Toggle\Model\Feature;
+use Pheature\Core\Toggle\Write\Feature;
 use Pheature\Core\Toggle\Write\FeatureId;
 use PHPUnit\Framework\TestCase;
 

test/Handler/RemoveStrategyTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Pheature\Test\Crud\Toggle\Handler;
+
+use Pheature\Core\Toggle\Write\Feature;
+use Pheature\Core\Toggle\Write\FeatureId;
+use Pheature\Core\Toggle\Write\FeatureRepository;
+use Pheature\Core\Toggle\Write\Strategy;
+use Pheature\Core\Toggle\Write\StrategyId;
+use Pheature\Core\Toggle\Write\StrategyType;
+use Pheature\Crud\Toggle\Command\RemoveStrategy as RemoveStrategyCommand;
+use Pheature\Crud\Toggle\Handler\RemoveStrategy;
+use PHPUnit\Framework\TestCase;
+
+final class RemoveStrategyTest extends TestCase
+{
+    private const FEATURE_ID = '252f6942-20ac-4b69-960a-d4246b1895c8';
+    private const STRATEGY_ID = 'ec721d39-4665-48b8-8e6f-0de3af19cbaf';
+    private const STRATEGY_TYPE = 'some_strategy';
+
+    public function testItShouldAddStrategyToAFeature(): void
+    {
+        $feature = Feature::withId(FeatureId::fromString(self::FEATURE_ID));
+        $feature->addStrategy(new Strategy(
+            StrategyId::fromString(self::STRATEGY_ID),
+            StrategyType::fromString(self::STRATEGY_TYPE)
+        ));
+        $command = RemoveStrategyCommand::withFeatureAndStrategyId(self::FEATURE_ID, self::STRATEGY_ID);
+        $repository = $this->createMock(FeatureRepository::class);
+        $repository->expects($this->once())
+            ->method('get')
+            ->with($this->isInstanceOf(FeatureId::class))
+            ->willReturn($feature);
+        $repository->expects($this->once())
+            ->method('save')
+            ->with($feature);
+
+        $this->assertCount(1, $feature->strategies());
+
+        $handler = new RemoveStrategy($repository);
+        $handler->handle($command);
+
+        $this->assertCount(0, $feature->strategies());
+    }
+}