Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the get following/get followers methods on the account object #10

Open
Riduidel opened this issue Nov 11, 2022 · 3 comments
Open

Comments

@Riduidel
Copy link

According to mastodon API, it's reasonably easy to get the following/followers accounts.

Could we have the equivalent methods on the account object of your API (maybe with some caching, but I don't know)

@Riduidel
Copy link
Author

Riduidel commented Nov 11, 2022

I'm starting a PR.

Would you prefer to have $client->getFollowedBy($account) or $account->getFollowedBy(). The second would seem more object-oriented, but would require the account to contain a reference to the client.

For the sake of simplicity, I think I'll go the first version. What do you think ?

@iansltx
Copy link
Contributor

iansltx commented Nov 11, 2022

This project is basically dead at the moment, so I'd suggest working on stuff on your fork 'til I have time to pick it back up. Going with the first option seems reasonable given how things are constructed right now though.

@Riduidel
Copy link
Author

As long as you(re still able to push onto composer packages, everything will be fine 😜

Riduidel added a commit to Riduidel/mastodon-rest that referenced this issue Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants